recipes icon indicating copy to clipboard operation
recipes copied to clipboard

Unable to create or use custom filters

Open nough opened this issue 2 years ago • 10 comments

Apologies, as I expect that this is a feature that is being worked on. In which case, I hope you don't mind having it as a list of things that don't currently work?

Unable to create custom filters: To access custom filters, I click on the toolbox at the top-right then files, then I click on the dropdown next to files and select Custom Filter. On each of the other list screens, I get a + button to create items, but not on the custom filter screen.

When custom filters exist, unable to edit the search I used the API to create two custom filters, with the search "plenty" and "yottam Ottolenghi". The word plenty is in the title of some of my external recipes, while "yottam ottolenghi" is a keyword. I could see these two custom filters existed from the API, but when using the List menu in Tandoor, I'm unable to even see the search keyword - only the title and who it's shared with.

I'm also unable to see if the custom filter has resulted in any items - so my next point may not be valid.

When custom filters exist, unable to use them for filtering in to recipe books I am able to edit the recipe book that I created for Plenty by Yottam Ottolenghi, and I can manually add recipes to the book. However, the book has a search filter which uses a custom filter. This was my reason for exploring the whole custom filter saga above. When one of these custom filters exist, I am able to select it in the recipe book edit menu. However this does not add the expected recipes to the recipe book.

nough avatar Aug 27 '22 20:08 nough

The interface needs some work to avoid some of this confusion.

image

Custom Filters can only be created from the search screen. The toolbox page you found can only be used to edit the name, share with another user (required if you share cookbooks with others) and delete the filter. Once created, the filters themselves cannot be modified.

smilerz avatar Aug 29 '22 13:08 smilerz

  • [ ] Add some help text to page to communicate that filters are created on search page
  • [ ] Add some help text to page to communicate that filters cannot be edited

smilerz avatar Aug 29 '22 13:08 smilerz

I don't know if I'm looking at the right place, but I don't think there is an add button on custom filter toolbox page.

I agree that the help text is all that's necessary - I've managed to make the rest of it work now.

nough avatar Aug 29 '22 14:08 nough

I did - I mentioned that there wasn't one there!

nough avatar Aug 29 '22 14:08 nough

I did - I mentioned that there wasn't one there!

thanks - I misread it.

smilerz avatar Aug 29 '22 14:08 smilerz

Honestly my preferred solution would be (and that's probably what I will implement in the long run)

  • edit filters by making a change after selecting them with some kind of indication or save button that appears
  • maybe also add a second "save as" button to make filters basically copieable
  • remove the model list page entirely as its overkill and seems out of place for something you can't really edit and just make a small list modal wher you can change a name or delete a filter

vabene1111 avatar Sep 03 '22 06:09 vabene1111