recipes icon indicating copy to clipboard operation
recipes copied to clipboard

Drag and Drop / Copy & Paste for Ingredients

Open michaelhthomas opened this issue 3 years ago • 8 comments
trafficstars

Is your feature request related to a problem? Please describe. It is rather frustrating to reorganize a recipe into steps (especially imported ones), without the ability to move ingredients from step to step.

Describe the solution you'd like Adding both drag and drop of ingredients between steps, as well as copy and paste for ingredients would go a long way to making this a better user experience.

Describe alternatives you've considered Having copy and paste by itself would definitely cover about 90% of the use case as well. Additionally, it would be very cool if it were possible to select multiple ingredients and copy/paste them all at once.

Additional context This is something I may be willing to have a shot at implementing, as I do have some Vue experience. Just let me know the best path to take, and if this is something you'd like to see!

michaelhthomas avatar Nov 23 '21 01:11 michaelhthomas

You can already drag and drop between steps, but the experience can be improved a lot. If you have ideas and skill on how to improve it I’d suggest putting a PR together, they’ve been very open to outside input.

smilerz avatar Nov 23 '21 01:11 smilerz

You're so right! I assumed it didn't work as I couldn't get dragging the items to make the page scroll, but turns out if I just zoom out my browser a bunch I can make it work. Making that scrolling more intuitive is definitely something I can look into.

michaelhthomas avatar Nov 23 '21 02:11 michaelhthomas

Multi-select is a great idea too. Or context menu -> move.

smilerz avatar Nov 23 '21 02:11 smilerz

@michaelhthomas - quick question: in your experience with Vue have you used any automated test frameworks?

smilerz avatar Nov 23 '21 15:11 smilerz

i am planning on rewriting the recipe editor, both from the UI and data perspective. The inability to scroll while dragging is something i noticed a while back, it was working before but has for some reason stopped at some point but i do not know when.

If you want feel free to take a crack at it, i would personally do the following things

  • [ ] add a "move to" option to the context menu of an ingredient (the three dots) which has a dropdown (either directly in the context menu or opens a modal) that lets you choose which step to add the ingredient to
  • [ ] add a "move down" and "move up" button that moves the ingredient (or step for that matter) up one step
  • [ ] fix the inability to scroll while dragging

the texts are just placeholders, not sure what to best call the buttons yet. If you wanna work on it let me know, if not i will leave it open for me to fix later.

edit: also copy paste wold be awesome but likely difficult ?! if you want feel free to try that as well but i think the other features will already be a big improvement.

vabene1111 avatar Nov 23 '21 16:11 vabene1111

pasting list of ingredients resolved with #1538

smilerz avatar Feb 14 '22 23:02 smilerz

  • [ ] add a "move from" button in the steps context menu

See https://github.com/TandoorRecipes/recipes/issues/1667#issuecomment-1214353117 (which I believe is a dupe of this)

Ram-Z avatar Aug 14 '22 12:08 Ram-Z