lupo-skill icon indicating copy to clipboard operation
lupo-skill copied to clipboard

Adds Search events by tags and time

Open arunimaChintu opened this issue 1 year ago • 8 comments

What kind of change does this PR introduce? Closes #298

https://github.com/Tanay-ErrorCode/lupo-skill/assets/99474881/202e6418-809a-4ab3-9f04-2ac481af1468

Key Changes: Search Input Placeholder: Updated to "Search by tags or date...". Filter Function: filterEvents now filters by tags and date. Search Logic: handleSearch now uses the updated filterEvents function to filter events based on tags and date. Search Event Handler: handleKeyPress ensures the search is triggered when pressing "Enter".

Issue Number:

Fixes # Snapshots/Videos:

Other information

arunimaChintu avatar Jul 04 '24 17:07 arunimaChintu

@Tanay-ErrorCode Please merge this now...

arunimaChintu avatar Jul 04 '24 17:07 arunimaChintu

@Tanay-ErrorCode Could you please assign it a level-3 as it had the backend involved.

arunimaChintu avatar Jul 04 '24 17:07 arunimaChintu

@arunimaChintu You have made many unnecessary changes. Only the files related to the search functionality needed to be changed.

Doraemon012 avatar Jul 04 '24 17:07 Doraemon012

@Doraemon012 Yeah! I tried to make it with the minimal changes... But then, to show the functionality of the search bar I added those extra events, which can be removed when necessary

arunimaChintu avatar Jul 04 '24 17:07 arunimaChintu

@Doraemon012 if you I can remove those uncessary Events... It was just an example to show the working... Not a big deal

arunimaChintu avatar Jul 04 '24 17:07 arunimaChintu

@arunimaChintu I am getting this error while running your code.

image

Tanay-ErrorCode avatar Jul 05 '24 03:07 Tanay-ErrorCode

@Tanay-ErrorCode My bad, am adjusting it as quick as possible, and removing these parts mentioned by you... Actually, I am new to this project...

arunimaChintu avatar Jul 05 '24 06:07 arunimaChintu

@Tanay-ErrorCode @Doraemon012 Removed all the unnecessary changes and it filters by titles now... Please merge this now

arunimaChintu avatar Jul 05 '24 15:07 arunimaChintu