table icon indicating copy to clipboard operation
table copied to clipboard

fix(table-core): ensure isSubRowSelected returns false if no subRows are selectable

Open remleduff opened this issue 1 year ago • 4 comments

This fixes https://github.com/TanStack/table/issues/5173

Keep track whether we've seen any selectable rows and if not return false from isSubRowSelected.

remleduff avatar Nov 04 '24 22:11 remleduff

☁️ Nx Cloud Report

CI is running/has finished running commands for commit d87e9bcc4e2e9ed5f008ce704dcb449c73bc1995. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Nov 07 '24 01:11 nx-cloud[bot]

@KevinVandy Do I need to do anything for this? It seems like the automated fixes are correct, but when I click through to the workflow its status is "failed".

remleduff avatar Nov 07 '24 16:11 remleduff

Any updates on this bugfix?

frankieali avatar Jan 13 '25 16:01 frankieali

Hi, is there anything that can be done to get this PR merged ? Would love to see it in the next release !

jfraudeau avatar Jul 18 '25 13:07 jfraudeau