table icon indicating copy to clipboard operation
table copied to clipboard

fix: invalidate cached values after updating accessor functions

Open takoshi opened this issue 1 year ago • 6 comments

What's this PR

https://github.com/TanStack/table/issues/5363

The above issue reported that getValues returns stale cached values after changing accessor functions.

This PR fixes it.

8cd8449: add unit tests f66f4e6: accessor functions are also held as cache, and it determines whether the cached data are fresh or stale.

takoshi avatar May 25 '24 07:05 takoshi

Is this good to merge?

EvanBarnesAZ avatar Aug 14 '24 17:08 EvanBarnesAZ

Would love to see this merged!

nickzelei avatar Sep 12 '24 22:09 nickzelei

@tannerlinsley can we get some eyes on this? :)

lifeiscontent avatar Oct 25 '24 00:10 lifeiscontent

Hi @tannerlinsley, may you have a look at this one?

jaxxreal avatar Jan 30 '25 19:01 jaxxreal

@KevinVandy , (sorry to tag, saw you're active merging fixes on this repo) is it possible to get a review on this PR? I'm running into this problem and would like to avoid running a fork if this has a path to merge to main

adamtowerz avatar Jan 31 '25 17:01 adamtowerz

I feel like I'm also running into this one fwiw.

erlandsona avatar Mar 29 '25 21:03 erlandsona