table
table copied to clipboard
column.enableGlobalFilter is not considered in the default implemenation of table.getColumnCanGlobalFilter
Describe the bug
When the first value of a column is neither a string nor a number, this column is considered to be not filterable according to the docs.
However, I would have expected that either:
- The default implementation of
table.getColumnCanGlobalFilterchecks whetherenableGlobalFilteris manually set totrueinside the columnDefs. - The "more specific" property (in that case on the columnDefs) takes precedence over the global table setting.
Your minimal, reproducible example
https://codesandbox.io/s/cocky-shape-3fct22?file=/src/App.js
Steps to reproduce
Type "hello" into the input box.
Expected behavior
Table is filtered correctly.
How often does this bug happen?
None
Screenshots or Videos
No response
Platform
- OS: MacOS
- Browser: Chrome
react-table version
8.10.7
TypeScript version
No response
Additional context
No response
Terms & Code of Conduct
- [X] I agree to follow this project's Code of Conduct
- [X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.
I am currently using
getColumnCanGlobalFilter: (c) =>
c.columnDef.enableGlobalFilter ??
Filters.getDefaultOptions!(table).getColumnCanGlobalFilter(c),
as a workaround. This uses the default implementation as a fallback in case no explicit value is set for enableGlobalFilter.
Filters is import { Filters } from "@tanstack/react-table";