table icon indicating copy to clipboard operation
table copied to clipboard

getIsAllRowsSelected returns unexpected result when using manual pagination

Open nathanpower opened this issue 1 year ago • 3 comments

Describe the bug

When using manualPagination and supplying a pageCount, and then calling the function returned by getToggleAllPageRowsSelectedHandler - would expect getIsAllRowsSelected to be false, but this is not the case.

In fact, I would expect it to be impossible for getIsAllRowsSelected to be true whenever pageCount is greater than 1 when using manualPagination - is this the wrong mental model or a bug?

Your minimal, reproducible example

https://codesandbox.io/p/sandbox/busy-jones-p3qqnd?file=%2Fsrc%2Fmain.tsx&selection=%5B%7B%22endColumn%22%3A6%2C%22endLineNumber%22%3A97%2C%22startColumn%22%3A1%2C%22startLineNumber%22%3A86%7D%5D

Steps to reproduce

  1. Click "Toggle all page rows selected"
  2. Observe output

Expected behavior

As a user I would expect it to be impossible for getIsAllRowsSelected to be true whenever pageCount is greater than 1 when using manualPagination, as the table can't know the ids of those rows in order to "select" them

How often does this bug happen?

Every time

Screenshots or Videos

No response

Platform

MacOS / Chrome

react-table version

8.7.9

TypeScript version

No response

Additional context

No response

Terms & Code of Conduct

  • [X] I agree to follow this project's Code of Conduct
  • [X] I understand that if my bug cannot be reliable reproduced in a debuggable environment, it will probably not be fixed and this issue may even be closed.

nathanpower avatar Mar 23 '23 12:03 nathanpower