table icon indicating copy to clipboard operation
table copied to clipboard

Published 20 hours ago • verified publisher icon TanStack

Remove yarn.lock from previously added examples

Open fekete965 opened this issue 2 years ago • 2 comments

I saw that in other PRs, people asked the author to remove the committed yarn.lock file.

None of the other example folders contains yarn.lock and I would like to match my previously added examples to that.

fekete965 avatar Aug 01 '22 22:08 fekete965

I will investigate the failure as soon as I have a bit more time this week!

fekete965 avatar Aug 03 '22 13:08 fekete965

#4232 seems to have a working solution regarding the workflow failure.

fekete965 avatar Sep 07 '22 20:09 fekete965

I think we actually do want yarn.locks in our examples, but we are looking at replacing it with pnpm in the future. Will close this for now

KevinVandy avatar Oct 29 '22 01:10 KevinVandy

@KevinVandy thanks for the heads up. I've seen in a few other PRs that removing the lock file was "mandatory". I thought I should follow that example. Shall we delete the branch?

fekete965 avatar Oct 30 '22 18:10 fekete965