table icon indicating copy to clipboard operation
table copied to clipboard

Feat react kitchen sink example

Open fekete965 opened this issue 2 years ago • 2 comments

Adding kitchen-sink to react examples:

  1. Sorting
  2. Pagination
  3. Filtering
  4. Resizable Columns
  5. Column Visibility
  6. Header Grouping
  7. Table Pins
  8. Row Selection

Screenshots: Screenshot 2022-08-01 at 22 51 20 Screenshot 2022-08-01 at 22 51 30

fekete965 avatar Aug 01 '22 21:08 fekete965

I will investigate the failure as soon as I have a bit more time this week!

fekete965 avatar Aug 03 '22 13:08 fekete965

#4232 seems to have a working solution regarding the workflow failure.

fekete965 avatar Sep 07 '22 20:09 fekete965

I tried to get this running, but for some reason could not. I know its been a long time so this PR might be abandoned

KevinVandy avatar Nov 15 '22 05:11 KevinVandy

@KevinVandy I'll need to update this, sorry for that! I believe certain parts of the API have changed.

fekete965 avatar Nov 15 '22 08:11 fekete965

@KevinVandy I'll need to update this, sorry for that! I believe certain parts of the API have changed.

@fekete965 yep, not blaming you at all. I'm going through and cleaning up PRs. Couldn't quite find a way to include this one yet.

If you do work on it, include entries for this example in the tsconfig.josn and package.json in order to yarn link everything together correctly for local development

KevinVandy avatar Nov 16 '22 00:11 KevinVandy

@KevinVandy I fixed the broken code bits and added the missing entry the tsconfig and package.json

fekete965 avatar Nov 16 '22 19:11 fekete965

@KevinVandy you might be able to point me in the right direction. Typecheck passes locally but fails here.

For some reason react-bootstrap causing some issues:

Error: examples/react/bootstrap/src/main.tsx(6,33): error TS2307: Cannot find module 'react-bootstrap' or its corresponding type declarations.

I have both bootstrap and react-bootstrap installed in the bootstrap example, I am not sure why TS throws an error. 😞

fekete965 avatar Nov 16 '22 21:11 fekete965

@fekete965 Did you merge main into your branch?

KevinVandy avatar Nov 16 '22 21:11 KevinVandy

@KevinVandy no, I didn't. I synchronised my forked repo, pulled main and rebased the PR on it.

fekete965 avatar Nov 16 '22 23:11 fekete965

@KevinVandy I managed to miss the bootstrap out of the package.json... 🤦 This caused the described issue above.

fekete965 avatar Nov 21 '22 15:11 fekete965

@fekete965 There are now conflicts. You may need to merge in main or rebase again

KevinVandy avatar Nov 22 '22 17:11 KevinVandy

@KevinVandy Thank you! I assume the conflict got resolved since the PR's been merged ? 🤔

fekete965 avatar Nov 22 '22 18:11 fekete965

@KevinVandy Thank you! I assume the conflict got resolved since the PR's been merged ? 🤔

Yeah I did it through the browser

KevinVandy avatar Nov 22 '22 19:11 KevinVandy

Amazing! Thank you for your help! 🙏

fekete965 avatar Nov 22 '22 20:11 fekete965