feat: add static function middleware support of basepath

Open fuegoio opened this issue 3 weeks ago • 3 comments

Hello 👋

I tried the new staticFunctionMiddleware, but I've found an issue as my application is hosted on a subpath (/docs). I propose to fix this, but I'm not sure the router basepath is the right variable to use. Ideally, I would prefer to use the import.meta.env. BASE_URL of Vite, as I think TSR files are quite similar to bundling assets, but I'm not sure it will work.

Let me know what you think and I'll change this straightaway. Thanks for this package!

Summary by CodeRabbit

Chores
- Updated request routing to support environment-configured base paths, enabling the application to function correctly when deployed to non-root server paths.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Nov 26 '25 10:11 fuegoio

Walkthrough

The static function middleware's fetch call now constructs a prefixed URL by joining an environment variable base path (TSS_ROUTER_BASEPATH) with the original URL before making the request. Response handling remains unchanged.

Changes

Cohort / File(s)	Summary
URL-Prefixed Fetch Request `packages/start-static-server-functions/src/staticFunctionMiddleware.ts`	Modified fetch call to use a base-path-prefixed URL constructed from the `TSS_ROUTER_BASEPATH` environment variable joined with the original URL, while preserving all downstream response handling logic.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Verify correct environment variable name and availability
Confirm URL joining logic handles edge cases (trailing slashes, leading slashes)
Ensure base path is optional or has proper fallback behavior

Poem

A rabbit hops with glee, 🐰 Base paths now aligned, Routes flow where they should be, No more lost to time! URLs dressed in their finest attire, This middleware climbs ever higher. 🚀

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'feat: add static function middleware support of basepath' clearly summarizes the main change: adding basepath support to the static function middleware.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

[ ] 📝 Generate docstrings

🧪 Generate unit tests (beta)

[ ] Create PR with unit tests
[ ] Post copyable unit tests in a comment

[!TIP]

📝 Customizable high-level summaries are now available in beta!

You can now customize how CodeRabbit generates the high-level summary in your pull requests — including its content, structure, tone, and formatting.

Provide your own instructions using the high_level_summary_instructions setting.

Format the summary however you like (bullet lists, tables, multi-section layouts, contributor stats, etc.).

Use high_level_summary_in_walkthrough to move the summary from the description to the walkthrough section.

Example instruction:

"Divide the high-level summary into five sections:

📝 Description — Summarize the main change in 50–60 words, explaining what was done.

📓 References — List relevant issues, discussions, documentation, or related PRs.

📦 Dependencies & Requirements — Mention any new/updated dependencies, environment variable changes, or configuration updates.

📊 Contributor Summary — Include a Markdown table showing contributions: | Contributor | Lines Added | Lines Removed | Files Changed |

✔️ Additional Notes — Add any extra reviewer context. Keep each section concise (under 200 words) and use bullet or numbered lists for clarity."

Note: This feature is currently in beta for Pro-tier users, and pricing will be announced later.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

Nov 26 '25 10:11 coderabbitai[bot]

View your CI Pipeline Execution ↗ for commit 8f4d04eee1e654d26a8b39994b30925be0148392

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	1m 11s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	7s	View ↗

☁️ Nx Cloud last updated this comment at 2025-11-26 11:26:46 UTC

Nov 26 '25 11:11 nx-cloud[bot]

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@5970

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@5970

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@5970

@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@5970

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/nitro-v2-vite-plugin@5970

@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@5970

@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@5970

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-ssr-query@5970

@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@5970

@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@5970

@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@5970

@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@5970

@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@5970

@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@5970

@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@5970

@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@5970

@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@5970

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-ssr-query-core@5970

@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@5970

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@5970

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@5970

@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@5970

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@5970

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-ssr-query@5970

@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@5970

@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@5970

@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@5970

@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@5970

@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@5970

@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@5970

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-static-server-functions@5970

@tanstack/start-storage-context

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-storage-context@5970

@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@5970

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@5970

@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@5970

commit: 8f4d04e

Nov 26 '25 11:11 pkg-pr-new[bot]