router icon indicating copy to clipboard operation
router copied to clipboard

test: add e2e test for ssr error handling

Open meouwu-dev opened this issue 7 months ago • 4 comments

e2e test for #3462

meouwu-dev avatar Jun 07 '25 12:06 meouwu-dev

View your CI Pipeline Execution ↗ for commit 2a8051a7ed7e3e5ed599b5d80af396880f488f11.

Command Status Duration Result
nx run-many --targets=test:eslint,test:unit,tes... ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-10 18:50:19 UTC

nx-cloud[bot] avatar Jun 07 '25 16:06 nx-cloud[bot]

so these tests fail until changes in the router are made?

brenelz avatar Jun 10 '25 00:06 brenelz

I guess according to the closed PR it is fixed in the alpha branch?

brenelz avatar Jun 10 '25 00:06 brenelz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/arktype-adapter@4339
@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/directive-functions-plugin@4339
@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/eslint-plugin-router@4339
@tanstack/history

npm i https://pkg.pr.new/TanStack/router/@tanstack/history@4339
@tanstack/react-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router@4339
@tanstack/react-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-devtools@4339
@tanstack/react-router-with-query

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-router-with-query@4339
@tanstack/react-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start@4339
@tanstack/react-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-client@4339
@tanstack/react-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-plugin@4339
@tanstack/react-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/react-start-server@4339
@tanstack/router-cli

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-cli@4339
@tanstack/router-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-core@4339
@tanstack/router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools@4339
@tanstack/router-devtools-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-devtools-core@4339
@tanstack/router-generator

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-generator@4339
@tanstack/router-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-plugin@4339
@tanstack/router-utils

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-utils@4339
@tanstack/router-vite-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/router-vite-plugin@4339
@tanstack/server-functions-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/server-functions-plugin@4339
@tanstack/solid-router

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router@4339
@tanstack/solid-router-devtools

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-router-devtools@4339
@tanstack/solid-start

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start@4339
@tanstack/solid-start-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-client@4339
@tanstack/solid-start-plugin

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-plugin@4339
@tanstack/solid-start-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/solid-start-server@4339
@tanstack/start-client-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-client-core@4339
@tanstack/start-plugin-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-plugin-core@4339
@tanstack/start-server-core

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-core@4339
@tanstack/start-server-functions-client

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-client@4339
@tanstack/start-server-functions-fetcher

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-fetcher@4339
@tanstack/start-server-functions-server

npm i https://pkg.pr.new/TanStack/router/@tanstack/start-server-functions-server@4339
@tanstack/valibot-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/valibot-adapter@4339
@tanstack/virtual-file-routes

npm i https://pkg.pr.new/TanStack/router/@tanstack/virtual-file-routes@4339
@tanstack/zod-adapter

npm i https://pkg.pr.new/TanStack/router/@tanstack/zod-adapter@4339

commit: 2a8051a

pkg-pr-new[bot] avatar Jun 10 '25 01:06 pkg-pr-new[bot]

@meouwu-dev thanks for these tests, it could help to avoid future regressions.

Could you maybe rebase this on the latest main?

Also instead of accessing the "links" through href could you please update to access these by way of test-id? something like "await page.getByTestId("error-handling-via-beforeLoad").click()"

nlynzaad avatar Jul 22 '25 16:07 nlynzaad