router icon indicating copy to clipboard operation
router copied to clipboard

refactor: Make (zod|valibot|arktype)-adapter agnostic

Open AhmedBaset opened this issue 9 months ago • 5 comments

@tanstack/react-router remains a dev dependency because it's still used in tests

AhmedBaset avatar Mar 22 '25 04:03 AhmedBaset

hmm we should deprecate valibot and arktype adapter since they are not required anymore. zod we still need, but just for the fallback.

@SeanCassiere @chorobin

schiller-manuel avatar Mar 22 '25 17:03 schiller-manuel

hmm we should deprecate valibot and arktype adapter since they are not required anymore. zod we still need, but just for the fallback.

Yup, I agree.

We should be able to merge this "as-is" and ask Tanner to mark @tanstack/arktype-adapter and @tanstack/valibot-adapter as deprecated on NPM.

@schiller-manuel maybe after devinxi we delete the zombie packages from the repo as a whole? or just throw an error asking the user to uninstall the package since it's no longer needed?

SeanCassiere avatar Mar 22 '25 21:03 SeanCassiere

wouldn't throw an error, just delete them and not publish them anymore

schiller-manuel avatar Mar 22 '25 21:03 schiller-manuel

wouldn't throw an error, just delete them and not publish them anymore

👍🏼

SeanCassiere avatar Mar 22 '25 22:03 SeanCassiere

@schiller-manuel maybe after devinxi we delete the zombie packages from the repo as a whole?

I reckon we can do that now, if it hasn't already been cleaned up?

birkskyum avatar Nov 19 '25 20:11 birkskyum