router icon indicating copy to clipboard operation
router copied to clipboard

`notFoundMode: 'root'` ignored when throw `notFound`

Open Semigradsky opened this issue 1 year ago • 1 comments

Which project does this relate to?

Router

Describe the bug

In doc I see (https://tanstack.com/router/latest/docs/framework/react/guide/not-found-errors#notfoundmode-root) the example:

If provided the path of `/posts/1/edit`, the following component structure will be rendered:

- <Root>
- - <Root.notFoundComponent>

The notFoundComponent of the __root__ route will be rendered because the `notFoundMode` is set to `root`.

But I see another behaviour if I generate notFound error myself.

Your Example Website or App

https://stackblitz.com/edit/github-ovpjyk-3gh8gb?file=src%2Fmain.tsx

Steps to Reproduce the Bug or Issue

Try to open "Not found" or "Sub Not found" - they will be work as expected.

Try to open "Generate Not found" page - it works in another way

Expected behavior

I expect that it will be works the same as described in documentation.

Screenshots or Videos

No response

Platform

  • OS: [e.g. macOS, Windows, Linux]
  • Browser: [e.g. Chrome, Safari, Firefox]
  • Version: [e.g. 91.1]

Additional context

No response

Semigradsky avatar Sep 26 '24 11:09 Semigradsky

Ok, I found in examples that notFound has not described option - global - https://tanstack.com/router/latest/docs/framework/react/api/router/notFoundFunction#examples

Throwing not found error like throw notFound({ global: true }) fixing my issue.

Please describe it better in documentation.

Semigradsky avatar Sep 26 '24 11:09 Semigradsky

Hi @schiller-manuel I was planning to grab this issue to update the docs, but global is deprecated. What should we do then?

Something like this? If so, I can create a MR for this.

Image

Christopher96u avatar Aug 01 '25 08:08 Christopher96u