query fix(query-core): add check to #combineResult for input parameter length to decide whether to return optimistic(old) or updated results

Issue #8781: fix(query-core): add check to #combineResult for input parameter length to decide whether to return optimistic(old) or updated results

May 28 '25 15:05 gopnik5

View your CI Pipeline Execution ↗ for commit 9c25bfe90674d1d934bf8c5af811411ae6e5ff51.

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 6s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1m 45s	View ↗

☁️ Nx Cloud last updated this comment at 2025-06-02 16:17:28 UTC

May 28 '25 15:05 nx-cloud[bot]

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9207

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9207

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9207

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9207

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9207

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9207

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9207

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9207

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9207

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9207

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9207

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9207

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9207

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9207

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9207

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9207

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9207

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9207

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9207

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9207

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9207

commit: 9c25bfe

May 28 '25 15:05 pkg-pr-new[bot]

Codecov Report

:x: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 59.62%. Comparing base (ff2b51a) to head (9c25bfe). :warning: Report is 274 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #9207       +/-   ##
===========================================
+ Coverage   45.30%   59.62%   +14.31%     
===========================================
  Files         209      138       -71     
  Lines        8257     5496     -2761     
  Branches     1863     1481      -382     
===========================================
- Hits         3741     3277      -464     
+ Misses       4076     1922     -2154     
+ Partials      440      297      -143

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`85.04% <ø> (ø)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`43.85% <ø> (ø)`
@tanstack/query-broadcast-client-experimental	`24.39% <ø> (ø)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`98.08% <0.00%> (-0.06%)`	:arrow_down:
@tanstack/query-devtools	`3.56% <ø> (ø)`
@tanstack/query-persist-client-core	`78.32% <ø> (ø)`
@tanstack/query-sync-storage-persister	`84.61% <ø> (ø)`
@tanstack/query-test-utils	`∅ <ø> (∅)`
@tanstack/react-query	`96.02% <ø> (ø)`
@tanstack/react-query-devtools	`10.00% <ø> (ø)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`100.00% <ø> (ø)`
@tanstack/solid-query	`78.20% <ø> (ø)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`100.00% <ø> (ø)`
@tanstack/svelte-query	`88.15% <ø> (ø)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`100.00% <ø> (ø)`
@tanstack/vue-query	`70.85% <ø> (ø)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

:rocket: New features to boost your workflow:

:snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
:package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

May 28 '25 15:05 codecov[bot]

please add a test that fails on main and is fixed with this PR. Otherwise, we a) don’t know what this fixes and b) it might regress again

Jun 02 '25 16:06 TkDodo

superseded by

#9618

Sep 05 '25 14:09 TkDodo