query icon indicating copy to clipboard operation
query copied to clipboard

chore: add typescript-eslint/require-await rule

Open minseong0324 opened this issue 8 months ago • 7 comments

ref: https://github.com/TanStack/query/pull/9011#issuecomment-2804846344

minseong0324 avatar Apr 15 '25 19:04 minseong0324

View your CI Pipeline Execution ↗ for commit e548b0b4c78715b40619e23e50b67d4c2dc2c018.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 45s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1s View ↗

☁️ Nx Cloud last updated this comment at 2025-06-28 15:52:59 UTC

nx-cloud[bot] avatar Apr 15 '25 19:04 nx-cloud[bot]

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@9029
@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@9029
@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@9029
@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@9029
@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@9029
@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@9029
@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@9029
@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@9029
@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@9029
@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@9029
@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@9029
@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@9029
@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@9029
@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@9029
@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@9029
@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@9029
@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@9029
@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@9029
@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@9029
@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@9029
@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@9029

commit: e548b0b

pkg-pr-new[bot] avatar Apr 15 '25 19:04 pkg-pr-new[bot]

seems like there are still some violations left (or were added in the meantime). Can you fix them in this PR ?

TkDodo avatar May 04 '25 09:05 TkDodo

seems like there are still some violations left (or were added in the meantime). Can you fix them in this PR ?

Sure, I’ll take care of it!

minseong0324 avatar May 04 '25 09:05 minseong0324

@minseong0324 Resolve ci error please

image

manudeli avatar May 06 '25 19:05 manudeli

@minseong0324 Resolve ci error please

From this point on, I've been figuring out the CI problem in query-codemods, but I haven't found a solution. Can you give me a little more time? Or, your opinion is also welcome :)

minseong0324 avatar May 06 '25 20:05 minseong0324

@minseong0324 Resolve ci error please

From this point on, I've been figuring out the CI problem in query-codemods, but I haven't found a solution. Can you give me a little more time? Or, your opinion is also welcome :)

Hi @lachlancollins, I noticed that this ESLint error only appears in the @tanstack/query-codemods package, and not elsewhere. Since you seem to be the most knowledgeable about the ESLint setup with @tanstack/config, would you mind helping us figure out?

I've double-checked the configuration and it seems consistent with other packages, so I'm not sure why the issue is isolated to this one. 🥲

manudeli avatar May 07 '25 19:05 manudeli

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 0.00%. Comparing base (7dafa93) to head (e548b0b). Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #9029       +/-   ##
==========================================
- Coverage   45.37%   0.00%   -45.38%     
==========================================
  Files         207      49      -158     
  Lines        8277    2204     -6073     
  Branches     1868     181     -1687     
==========================================
- Hits         3756       0     -3756     
+ Misses       4080    2083     -1997     
+ Partials      441     121      -320     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental ∅ <ø> (∅)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister ∅ <ø> (∅)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods 0.00% <ø> (ø)
@tanstack/query-core ∅ <ø> (∅)
@tanstack/query-devtools ∅ <ø> (∅)
@tanstack/query-persist-client-core ∅ <ø> (∅)
@tanstack/query-sync-storage-persister ∅ <ø> (∅)
@tanstack/query-test-utils ∅ <ø> (∅)
@tanstack/react-query ∅ <ø> (∅)
@tanstack/react-query-devtools ∅ <ø> (∅)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client ∅ <ø> (∅)
@tanstack/solid-query ∅ <ø> (∅)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client ∅ <ø> (∅)
@tanstack/svelte-query ∅ <ø> (∅)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client ∅ <ø> (∅)
@tanstack/vue-query ∅ <ø> (∅)
@tanstack/vue-query-devtools ∅ <ø> (∅)
:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jun 28 '25 15:06 codecov[bot]