This PR fixes #7401

Aug 20 '24 10:08 divdavem

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 62dc7a876d707057b25dd245dd93c64c6bbe8bca. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Aug 21 '24 23:08 nx-cloud[bot]

commit: 62dc7a8

@tanstack/angular-query-devtools-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@7923

@tanstack/angular-query-experimental

pnpm add https://pkg.pr.new/@tanstack/angular-query-experimental@7923

@tanstack/eslint-plugin-query

pnpm add https://pkg.pr.new/@tanstack/eslint-plugin-query@7923

@tanstack/query-async-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-async-storage-persister@7923

@tanstack/query-broadcast-client-experimental

pnpm add https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@7923

@tanstack/query-core

pnpm add https://pkg.pr.new/@tanstack/query-core@7923

@tanstack/query-devtools

pnpm add https://pkg.pr.new/@tanstack/query-devtools@7923

@tanstack/query-persist-client-core

pnpm add https://pkg.pr.new/@tanstack/query-persist-client-core@7923

@tanstack/query-sync-storage-persister

pnpm add https://pkg.pr.new/@tanstack/query-sync-storage-persister@7923

@tanstack/react-query

pnpm add https://pkg.pr.new/@tanstack/react-query@7923

@tanstack/react-query-devtools

pnpm add https://pkg.pr.new/@tanstack/react-query-devtools@7923

@tanstack/react-query-next-experimental

pnpm add https://pkg.pr.new/@tanstack/react-query-next-experimental@7923

@tanstack/react-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/react-query-persist-client@7923

@tanstack/solid-query

pnpm add https://pkg.pr.new/@tanstack/solid-query@7923

@tanstack/solid-query-devtools

pnpm add https://pkg.pr.new/@tanstack/solid-query-devtools@7923

@tanstack/solid-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/solid-query-persist-client@7923

@tanstack/svelte-query

pnpm add https://pkg.pr.new/@tanstack/svelte-query@7923

@tanstack/svelte-query-devtools

pnpm add https://pkg.pr.new/@tanstack/svelte-query-devtools@7923

@tanstack/svelte-query-persist-client

pnpm add https://pkg.pr.new/@tanstack/svelte-query-persist-client@7923

@tanstack/vue-query

pnpm add https://pkg.pr.new/@tanstack/vue-query@7923

@tanstack/vue-query-devtools

pnpm add https://pkg.pr.new/@tanstack/vue-query-devtools@7923

Open in Stackblitz

More templates

Aug 21 '24 23:08 pkg-pr-new[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 86.58%. Comparing base (c7fb5fd) to head (62dc7a8). Report is 21 commits behind head on main.

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #7923       +/-   ##
===========================================
+ Coverage   44.64%   86.58%   +41.93%     
===========================================
  Files         187       18      -169     
  Lines        7090      231     -6859     
  Branches     1575       34     -1541     
===========================================
- Hits         3165      200     -2965     
+ Misses       3562       31     -3531     
+ Partials      363        0      -363

Components	Coverage Δ
@tanstack/angular-query-devtools-experimental	`∅ <ø> (∅)`
@tanstack/angular-query-experimental	`86.58% <ø> (ø)`
@tanstack/eslint-plugin-query	`∅ <ø> (∅)`
@tanstack/query-async-storage-persister	`∅ <ø> (∅)`
@tanstack/query-broadcast-client-experimental	`∅ <ø> (∅)`
@tanstack/query-codemods	`∅ <ø> (∅)`
@tanstack/query-core	`∅ <ø> (∅)`
@tanstack/query-devtools	`∅ <ø> (∅)`
@tanstack/query-persist-client-core	`∅ <ø> (∅)`
@tanstack/query-sync-storage-persister	`∅ <ø> (∅)`
@tanstack/react-query	`∅ <ø> (∅)`
@tanstack/react-query-devtools	`∅ <ø> (∅)`
@tanstack/react-query-next-experimental	`∅ <ø> (∅)`
@tanstack/react-query-persist-client	`∅ <ø> (∅)`
@tanstack/solid-query	`∅ <ø> (∅)`
@tanstack/solid-query-devtools	`∅ <ø> (∅)`
@tanstack/solid-query-persist-client	`∅ <ø> (∅)`
@tanstack/svelte-query	`∅ <ø> (∅)`
@tanstack/svelte-query-devtools	`∅ <ø> (∅)`
@tanstack/svelte-query-persist-client	`∅ <ø> (∅)`
@tanstack/vue-query	`∅ <ø> (∅)`
@tanstack/vue-query-devtools	`∅ <ø> (∅)`

Aug 21 '24 23:08 codecov[bot]

Hi @arnoud-dv is there a way to see how we can work together my Team and you to finish the remaining elements on angular-query. We are really interested to push this package for more visibility, this include removing the experimental flag. Thx

Aug 27 '24 08:08 ExFlo

is there a way to see how we can work together my Team and you

Sure, contact me on the TanStack Discord or Twitter.

I'll be going on holiday next 3 weeks, feel free to contact me but not sure if I'll be online.

Also note that some open issues to be resolved for a non-experimental release are not just code in the adapter:

There's a bug where Angular versions in at least a pnpm based mono repo such as TanStack Query wrongly resolve to each other, making the following point not entirely possible for now. I will try to reproduce and report it on the Angular CLI Github.
Ensure ongoing compatibility with at least Angular versions under LTS or active support.
Angular signals themselves are under development and particularly type narrowing is still a challenge. But I did see some very promising developments on type narrowing. Need to look into if those developments resolve the narrowing issues.

Aug 29 '24 12:08 arnoud-dv

@arnoud-dv Thank you for merging my PR!

Aug 30 '24 08:08 divdavem

fix(angular-query): fix type of isSuccess, isError, isPending, isIdle

☁️ Nx Cloud Report

Codecov Report