query icon indicating copy to clipboard operation
query copied to clipboard

[WIP] [Experiment] Refactor Subscribable and NotifyManager to TanStack Store

Open crutchcorn opened this issue 1 year ago • 5 comments

This PR refactors the existing implementations of NotifyManager and Subscribable instances into TanStack Store utilities as an experiment to see if we're able to consolidate on the tooling we want to use for our projects.

This is a WIP and experiment; this may not ultimately yield any changes to Query.

crutchcorn avatar Jan 31 '24 09:01 crutchcorn

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
query ⬜️ Ignored (Inspect) Jan 31, 2024 9:54am

vercel[bot] avatar Jan 31 '24 09:01 vercel[bot]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 98679645258e8591299485c51bcc786274bc2616. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:eslint,test:lib,test:types,test:build,build --exclude=examples/**

Sent with 💌 from NxCloud.

nx-cloud[bot] avatar Jan 31 '24 09:01 nx-cloud[bot]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 98679645258e8591299485c51bcc786274bc2616:

Sandbox Source
@tanstack/query-example-angular-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-svelte-basic Configuration
@tanstack/query-example-vue-basic Configuration

codesandbox-ci[bot] avatar Jan 31 '24 09:01 codesandbox-ci[bot]

looks good, but the failing tests uses the focusManager, so I think we'd need to look into this

TkDodo avatar Feb 03 '24 11:02 TkDodo

looking at the preview build, onlineManager seems to work fine, but focusManager does not - I can't get window focus refetching to work.

TkDodo avatar Feb 03 '24 11:02 TkDodo