query icon indicating copy to clipboard operation
query copied to clipboard

chore(react-query): drop support for React17

Open illuzan opened this issue 2 years ago • 2 comments

Closes: #4683

illuzan avatar Dec 23 '22 21:12 illuzan

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ff92ee231e7391092c9127524fb7ee713d9509b0:

Sandbox Source
@tanstack/query-example-react-basic-typescript Configuration
@tanstack/query-example-solid-basic-typescript Configuration
@tanstack/query-example-vue-basic Configuration

codesandbox-ci[bot] avatar Dec 23 '22 21:12 codesandbox-ci[bot]

Thank you. I think there are a couple of things missing:

  • look for REACTJS_VERSION string
  • most things in jest.setup.ts can go:

https://github.com/TanStack/query/blob/4ae99561ca3383d6de3f4aad656a49ba4a17b57a/packages/react-query/jest.setup.ts#L9-L39

  • this as well: https://github.com/TanStack/query/blob/c376158afaddf7cd92a85491c3f18c1b123efe4b/packages/react-query/src/tests/ssr-hydration.test.tsx#L17
  • we can always use ReactDOM.hydrate: https://github.com/TanStack/query/blob/c376158afaddf7cd92a85491c3f18c1b123efe4b/packages/react-query/src/tests/ssr-hydration.test.tsx#L19-L35
  • this is also a leftover that can go: https://github.com/TanStack/query/blob/11f08c37d56c8aa5d9b28d8422842bc1a147c487/package.json#L38

TkDodo avatar Dec 24 '22 08:12 TkDodo

@illuzan will you continue to work on this PR or should someone else take over?

TkDodo avatar Jan 05 '23 09:01 TkDodo

Yes, I will work on this I was just busy with work stuff.

illuzan avatar Jan 05 '23 09:01 illuzan

@TkDodo I have pushed an update, can you take a look?

illuzan avatar Jan 10 '23 07:01 illuzan

there are conflicts with v5, can you please fix them?

TkDodo avatar Jan 10 '23 08:01 TkDodo

why was this PR closed @illuzan ?

TkDodo avatar Jan 10 '23 08:01 TkDodo

Looks like I messed up pushing it again.

illuzan avatar Jan 10 '23 09:01 illuzan