chore(react-query): drop support for React17
Closes: #4683
This pull request is automatically built and testable in CodeSandbox.
To see build info of the built libraries, click here or the icon next to each commit SHA.
Latest deployment of this branch, based on commit ff92ee231e7391092c9127524fb7ee713d9509b0:
| Sandbox | Source |
|---|---|
| @tanstack/query-example-react-basic-typescript | Configuration |
| @tanstack/query-example-solid-basic-typescript | Configuration |
| @tanstack/query-example-vue-basic | Configuration |
Thank you. I think there are a couple of things missing:
- look for
REACTJS_VERSIONstring - most things in
jest.setup.tscan go:
https://github.com/TanStack/query/blob/4ae99561ca3383d6de3f4aad656a49ba4a17b57a/packages/react-query/jest.setup.ts#L9-L39
- this as well: https://github.com/TanStack/query/blob/c376158afaddf7cd92a85491c3f18c1b123efe4b/packages/react-query/src/tests/ssr-hydration.test.tsx#L17
- we can always use
ReactDOM.hydrate: https://github.com/TanStack/query/blob/c376158afaddf7cd92a85491c3f18c1b123efe4b/packages/react-query/src/tests/ssr-hydration.test.tsx#L19-L35 - this is also a leftover that can go: https://github.com/TanStack/query/blob/11f08c37d56c8aa5d9b28d8422842bc1a147c487/package.json#L38
@illuzan will you continue to work on this PR or should someone else take over?
Yes, I will work on this I was just busy with work stuff.
@TkDodo I have pushed an update, can you take a look?
there are conflicts with v5, can you please fix them?
why was this PR closed @illuzan ?
Looks like I messed up pushing it again.