useSyncExternalStore should have a correct/frozen getServerSnapshot

Open TkDodo opened this issue 2 years ago • 1 comments

I think we should also do this in v5

@Ephem

sandbox that shows potential mismatch:

https://codesandbox.io/p/sandbox/epic-wind-bwwhes?file=%2Fapp%2Fpage.tsx&selection=%5B%7B%22endColumn%22%3A6%2C%22endLineNumber%22%3A1%2C%22startColumn%22%3A6%2C%22startLineNumber%22%3A1%7D%5D

from

https://github.com/TanStack/query/discussions/5357

Dec 23 '22 07:12 TkDodo

Yeah, I think we could probably do it in a minor, it doesn't break anything, but it will probably be easier to include together with the other work being done on hydration. :smiley:

Dec 25 '22 10:12 Ephem