query icon indicating copy to clipboard operation
query copied to clipboard

feat(solid-query): Solid Query Adapter For TanStack Query

Open ardeora opened this issue 2 years ago • 1 comments

This pull request aims to add the TanStack Query adapter for Solid JS. This pull request will add the following key primitives to the package.

  • createQuery
  • createQueries
  • createInfiniteQueries
  • createMutation
  • useIsFetching
  • useIsMutating
  • useQueryClient
  • QueryClient
  • QueryClientProvider

The adapter docs have been updated as well as examples have been added. Please let me know how I can help get this massive PR accepted in the beta branch

Acknowledgments

The work on solid-query could not have been possible without

  • @lukesmurray
  • @jennyckaplan

ardeora avatar Sep 21 '22 04:09 ardeora

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4a6586abe0714903f5b0f1650b887c530356d140:

Sandbox Source
@tanstack/query-example-react-basic Configuration
@tanstack/query-example-react-basic-typescript Configuration

codesandbox-ci[bot] avatar Sep 21 '22 04:09 codesandbox-ci[bot]

thanks @TkDodo. we can remove the lock file.

couple questions.

do we need to do anything to get our examples listed on the website with codesandbox integration?

do we need all tests passing to get this merged and published on npm? currently there are two failing tests.

lastly wanted to confirm any of the changes we made outside the solid-query and examples folders, for instance, changes to rollup.config.ts are ok before we merge.

lukesmurray avatar Sep 22 '22 19:09 lukesmurray

lastly wanted to confirm any of the changes we made outside the solid-query and examples folders, for instance, changes to rollup.config.ts are ok before we merge.

I don't know much about the rollup config, I think @DamianOsipiuk does :)

TkDodo avatar Sep 23 '22 12:09 TkDodo

This PR can probably be closed and we can use #4211 instead where I rebased the changes onto main.

lukesmurray avatar Sep 23 '22 15:09 lukesmurray