TanStack
fix(devtools): stop devtools explorer from un-expanding when data is fetched
Fixes #3681
Reverts the change in #2949 from function handleEntry to component HandleEntry, but keeps the added types.
I'm not actually sure why that fixes the un-expanding, but it does.
thank you. there are still type errors, please have a look:
Error: src/devtools/tests/Explorer.test.tsx(42,11): error TS2322: Type '{ label: string; toggleExpanded: Mock<any, any>; pageSize: number; expanded: false; subEntryPages: { label: string; }[][]; HandleEntry: () => Element; value: undefined; subEntries: never[]; type: string; }' is not assignable to type 'IntrinsicAttributes & RendererProps'. Property 'HandleEntry' does not exist on type 'IntrinsicAttributes & RendererProps'. Did you mean 'handleEntry'?
When running yarn test:ci, prettier fails on file types/index.d.ts
This also happens when I check out origin/master on a new gitpod workspace, and try to run the tests.
When I removed the semicolons in types/index.d.ts, the workflow tests seemed to pass fine, but the type files aren't tracked by git.
Great! In that case, the type errors are fixed, and data explorer is staying expanded.
can you do me a favour and rebase this to the beta branch? Release is imminent and I'd want to avoid merge conflicts because we moved lots of things around. thanks
@boathouse2112 sorry that I missed this somehow. Can you please fix the conflicts? Then this should be good to merge 🚀
FYI, I will close stale PRs somewhen next week. Please either address the open comments / resolve the merge conflicts or this PR will be closed. Thanks 🙏
If someone else wants to take over this PR, please do
@boathouse2112 I'll still attribute you as contributor alongside @zorzysty to the upcoming release. Thanks for your contribution 🙌