form icon indicating copy to clipboard operation
form copied to clipboard

fix: enhance form state merging with error map support

Open jiji-hoon96 opened this issue 1 month ago • 4 comments

🎯 Changes

  • We reverted FormApi.validateSync to store global errors only as existing string formats, ensuring form state and field meta synchronization remains compatible with previous behavior.
  • We added a regression test to verify that field metadata is passed when errors delivered from the server are merged using mergeForm.

✅ Checklist

  • [x] I have followed the steps in the Contributing guide.
  • [x] I have tested this code locally with pnpm test:pr.

🚀 Release Impact

  • [x] This change affects published code, and I have generated a changeset.
  • [x] This change is docs/CI/dev-only (no release).

jiji-hoon96 avatar Oct 24 '25 09:10 jiji-hoon96

⚠️ No Changeset found

Latest commit: cbaae227f43bc27f8ecb7139c91b9be4322caa4e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 24 '25 09:10 changeset-bot[bot]

View your CI Pipeline Execution ↗ for commit cbaae227f43bc27f8ecb7139c91b9be4322caa4e

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 29s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 25s View ↗

☁️ Nx Cloud last updated this comment at 2025-10-24 09:41:49 UTC

nx-cloud[bot] avatar Oct 24 '25 09:10 nx-cloud[bot]

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1824
@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1824
@tanstack/form-devtools

npm i https://pkg.pr.new/@tanstack/form-devtools@1824
@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1824
@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1824
@tanstack/react-form-devtools

npm i https://pkg.pr.new/@tanstack/react-form-devtools@1824
@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1824
@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1824
@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1824

commit: cbaae22

pkg-pr-new[bot] avatar Oct 24 '25 09:10 pkg-pr-new[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 90.72%. Comparing base (6892ed0) to head (cbaae22). :warning: Report is 39 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1824      +/-   ##
==========================================
+ Coverage   90.35%   90.72%   +0.36%     
==========================================
  Files          38       38              
  Lines        1752     1811      +59     
  Branches      444      468      +24     
==========================================
+ Hits         1583     1643      +60     
+ Misses        149      148       -1     
  Partials       20       20              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 24 '25 09:10 codecov[bot]