form icon indicating copy to clipboard operation
form copied to clipboard

fix(form-core): fix formApi.reset() in form onSubmit

Open djordje-st opened this issue 3 months ago • 7 comments

Fixes #1681

djordje-st avatar Aug 28 '25 17:08 djordje-st

This addresses the resetting values, but what about meta properties like isSubmitting, isSubmitted etc.?

They might still be affected

LeCarbonator avatar Aug 28 '25 18:08 LeCarbonator

View your CI Pipeline Execution ↗ for commit 3dbed4af226a7d06d54bfe852d087e94546e24c1

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 7s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-08-30 10:21:24 UTC

nx-cloud[bot] avatar Aug 28 '25 18:08 nx-cloud[bot]

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1718
@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1718
@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1718
@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1718
@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1718
@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1718
@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1718

commit: 3dbed4a

pkg-pr-new[bot] avatar Aug 28 '25 18:08 pkg-pr-new[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 90.62%. Comparing base (24e30ab) to head (3dbed4a). :warning: Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1718      +/-   ##
==========================================
+ Coverage   90.52%   90.62%   +0.10%     
==========================================
  Files          37       37              
  Lines        1688     1696       +8     
  Branches      421      427       +6     
==========================================
+ Hits         1528     1537       +9     
+ Misses        143      142       -1     
  Partials       17       17              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 28 '25 18:08 codecov[bot]

@LeCarbonator good shout, should be handled now

djordje-st avatar Aug 30 '25 08:08 djordje-st

Not to be pushy or anything, but I would really appreciate to have this bugfix released. Is there any kind of timeline on the horizon for shipping this PR?

gregorbg avatar Oct 04 '25 19:10 gregorbg

+1, it would be great to get this fixed. I have used the setTimeout workaround (discussed in #1681 ), but it would be nice to be able to remove it.

matthewbbrandt avatar Nov 25 '25 17:11 matthewbbrandt