form icon indicating copy to clipboard operation
form copied to clipboard

fix(form-core): canSubmitWhenInvalid not allowing form submission

Open 814k31 opened this issue 4 months ago • 4 comments

814k31 avatar Jul 25 '25 06:07 814k31

This might be a confusion about what canSubmitWhenInvalid is supposed to do. The purpose is that canSubmit does not trigger an early return and will retry validation before submission. It should not call onSubmit if errors showed up during validation.

LeCarbonator avatar Jul 25 '25 20:07 LeCarbonator

View your CI Pipeline Execution ↗ for commit 1fde4b69f64950772d3fcd688b76c4f8c40e43ad

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 27s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-07-30 13:41:59 UTC

nx-cloud[bot] avatar Jul 28 '25 04:07 nx-cloud[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 90.37%. Comparing base (9e9cccd) to head (1fde4b6). :warning: Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1632      +/-   ##
==========================================
+ Coverage   89.57%   90.37%   +0.79%     
==========================================
  Files          34       36       +2     
  Lines        1497     1621     +124     
  Branches      371      385      +14     
==========================================
+ Hits         1341     1465     +124     
  Misses        139      139              
  Partials       17       17              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jul 30 '25 13:07 codecov[bot]