form icon indicating copy to clipboard operation
form copied to clipboard

[Solid.js] feat: add withForm and createAppForm APIs

Open crutchcorn opened this issue 8 months ago • 3 comments

TODOs

  • [ ] Write docs
  • [ ] Receive code review from community to validate if useFieldContext should return a signal or stay as-is

crutchcorn avatar Apr 25 '25 10:04 crutchcorn

View your CI Pipeline Execution ↗ for commit 1a851ee901f6e70d8703f2347d3702c3b2aa1811.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 43s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-25 10:27:30 UTC

nx-cloud[bot] avatar Apr 25 '25 10:04 nx-cloud[bot]

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1453
@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1453
@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1453
@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1453
@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1453
@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1453
@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1453

commit: 1a851ee

pkg-pr-new[bot] avatar Apr 25 '25 10:04 pkg-pr-new[bot]

Codecov Report

Attention: Patch coverage is 93.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 93.15%. Comparing base (daf8e57) to head (1a851ee). Report is 70 commits behind head on main.

Files with missing lines Patch % Lines
packages/solid-form/src/makeFormCreate.tsx 93.33% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1453      +/-   ##
==========================================
+ Coverage   88.83%   93.15%   +4.31%     
==========================================
  Files          31        3      -28     
  Lines        1379       73    -1306     
  Branches      347        4     -343     
==========================================
- Hits         1225       68    -1157     
+ Misses        137        5     -132     
+ Partials       17        0      -17     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Apr 25 '25 10:04 codecov[bot]

I've done some work on this and got tests passing and addressed the comments in #1597

Can we consolidate the efforts and get this going? I'm willing to help or take over.

MAST1999 avatar Jun 29 '25 21:06 MAST1999

Closing in favor of your work in #1597 @MAST1999 - thanks for taking this on/over! :D

crutchcorn avatar Jul 05 '25 10:07 crutchcorn