form icon indicating copy to clipboard operation
form copied to clipboard

docs(angular): use type annotations instead of casting

Open harry-whorlow opened this issue 8 months ago • 4 comments

Following some remarks from twitter, and as discussed in the maintainers channel we should avoid casting in the docs. This pr removes the casting defaultValues in examples and docs.

harry-whorlow avatar Apr 20 '25 19:04 harry-whorlow

View your CI Pipeline Execution ↗ for commit bf1186c3af8f3fd340e19f3de58e34d158c85805.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 1m 6s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-05-25 18:07:27 UTC

nx-cloud[bot] avatar Apr 20 '25 19:04 nx-cloud[bot]

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1433
@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1433
@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1433
@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1433
@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1433
@tanstack/svelte-form

npm i https://pkg.pr.new/@tanstack/svelte-form@1433
@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1433

commit: bf1186c

pkg-pr-new[bot] avatar Apr 20 '25 19:04 pkg-pr-new[bot]

Ahh, sorry @harry-whorlow for not catching this prior to a closed PR. I'm in favor of type annotations; what does casting bring to us otherwise?

crutchcorn avatar May 16 '25 14:05 crutchcorn

@crutchcorn It wasn't so much as me closing it in favour of casting, I'm for annotations too, I just didn’t want to bother the other maintainers with it for now 🙂

But, I can reopen it

harry-whorlow avatar May 16 '25 15:05 harry-whorlow

Closing this as I don't see the arguments for it much. Just trying to clean up our PRs

crutchcorn avatar Dec 01 '25 09:12 crutchcorn