form icon indicating copy to clipboard operation
form copied to clipboard

feat(svelte-form): Add Svelte adapter

Open dummdidumm opened this issue 9 months ago • 5 comments

This implements a Svelte adapter for the form package. API-wise it's somewhere inbetween Solid and React (createForm is used like Solid's, getting the field state from within a snippet is more like React). Added basic tests and two examples.

Superseeds #1107

dummdidumm avatar Mar 07 '25 20:03 dummdidumm

View your CI Pipeline Execution ↗ for commit f561f844af2804085f823826313364f29b36eab9.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 3s View ↗
nx run-many --target=build --exclude=examples/** ✅ Succeeded 20s View ↗

☁️ Nx Cloud last updated this comment at 2025-04-17 23:43:45 UTC

nx-cloud[bot] avatar Mar 07 '25 23:03 nx-cloud[bot]

Let me know if you want any help with this 👍 my pr went stale since I was in need of someone to pair/review with but I am still very much interested in landing this

43081j avatar Mar 08 '25 07:03 43081j

Is this ready for testing it in a project?

Dreaming-Codes avatar Mar 15 '25 11:03 Dreaming-Codes

Is this ready for testing it in a project?

And if it is, would love to know if there is a nightly build :), Otherwise what is left / where we can help.

niemyjski avatar Mar 15 '25 20:03 niemyjski

Is this ready for testing it in a project?

what is left / where we can help.

I see an error in types that has an @ts/error with no actual error, and as someone else pointed that import failing. I think the reviews need to approve and best guess they will once those two failing tests pass from the fixes I mentioned...

JonathonRP avatar Mar 15 '25 20:03 JonathonRP

some of the CI failure seems unrelated, some eslint.config.js stuff from the react package

this all looks good other than the failing CI though 👍 i left a few very minor comments but nothing much

there's an unfortunate amount of any, unsafe casts (as never) and such. but there's not a huge amount we can do about them given the circular references and overly deep type inference

43081j avatar Mar 23 '25 22:03 43081j

i tried this out locally and dug around the types a bit etc, all seems pretty good

maybe we can get some kind of nightly build sorted soon

43081j avatar Mar 27 '25 11:03 43081j

nightly build would be great. Any thing the community can help with?

niemyjski avatar Mar 30 '25 02:03 niemyjski