Gaël Bonithon

> Meanwhile, everything else you mentioned is addressed [in this commit](https://github.com/pulsar-edit/pulsar/pull/859/commits/5e84a7cda414e7b6fd6aa3db42e16ac6d538ab08). I can confirm it's fixed, but I'm not sure if it's best to use the same color for command...

It may be a little better, but it's not fixed. The case I added in https://github.com/tree-sitter/tree-sitter-bash/issues/242#issuecomment-1906662462 is not fixed: ```sh reff="${f/'-roff2html'*/'-ref'}.html" ```  It no longer breaks the highlighting in...

@savetheclocktower Also opening this file crashes the editor for me after this change: https://gitlab.xfce.org/apps/mousepad/-/blob/9733d85a611770c72b59c61525766187d99af0f3/tests/functions-test.sh ``` Attempting to call a function in a renderer window that has been closed or released....

> The “good news” on the crash is that that file seems to come from from the github package, so it's unrelated to the parser change. But let me know...

> To be clear: this just happened for the first time when you updated to a build that you downloaded from https://github.com/pulsar-edit/pulsar/pull/906's CI artifacts? Yes I was using Pulsar-1.113.2024020421.AppImage from...

I can confirm that https://github.com/pulsar-edit/pulsar/issues/873#issuecomment-1941375562 is fixed now :+1:

FWIW things appear more broken with the built-in Base16 Tomorrow Dark theme (for example user-defined types are no longer highlighted). Is there an easy way to test #859 without rebuilding...

Is #859 supposed to fix the other themes too, or are you only taking care of One Dark at first? Also, with One Dark, is highlighting variables when declaring or...

> If you find a place where a variable is not scoped as variable when being declared or assigned, then that is a bug. Testing the latest #859 for the...

This could be a bug: structure members are not highlighted in this definition (whatever the theme): ```c static const struct wl_registry_listener registry_listener = { .global = registry_global, .global_remove = registry_global_remove,...