Baptiste Clavié

Results 130 comments of Baptiste Clavié

Also, migration to use NVim-LSP instead of coc.nvim (and probably also ALE) : - https://github.com/neovim/nvim-lspconfig - https://github.com/hrsh7th/nvim-compe (see https://github.com/neovim/nvim-lspconfig/wiki/Autocompletion) - https://github.com/williamboman/nvim-lsp-installer (or https://github.com/kabouzeid/nvim-lspinstall ?)

Another case which would need to move the `LoggerPass` while the compiler is optimizing the services (or after ?) rather than before. I have the following services : ``` xml...

In that case, I think the `ResolveDefinitionTemplatePass` should maybe be moved into the before optimization pass, so that the dependency are kept, and passes such as the `LoggerPass` could operate...

Mmh so maybe the `LoggerPass` should kind of copy what the `ResolveDefinitionTemplatePass` does ? But that would kind of be repetitive (and how would the main one works then ?)

I don't know if it would be optimized, but maybe if, when not finding any `logger` argument, it could try to lookup in a parent service if there is one...

Thought about it, but as there's already the request processor on monolog, didn't think it'd be useful : https://github.com/Seldaek/monolog/blob/master/src/Monolog/Processor/WebProcessor.php

> Last thing, it's possible that the SentryHandler will not support the "extra" key from log context in future releases. Source ? Anyway, I managed to readd the request integration....

Done. I'll try to find a way to set the global hub state, even though it's repulsive (through a factory or a configurator, probably)

IIRC, it was because sentry relies on a global state, preventing from really having multiple handlers. I can't remember having made any progress, but I think maybe they had some...

FWIW, I manually type the `use` when I need to add an alias or a namespace (`use Foo;` and `Foo\Bar`, `Foo\Baz`)... And then I mess the order because I like...