ui icon indicating copy to clipboard operation
ui copied to clipboard

fix(config/storybook): add scss and cdn config

Open jmfrancois opened this issue 3 years ago • 3 comments

What is the problem this PR is trying to solve?

storybook do not work with react preset but it work with lib preset. the current status is our config try to merge two webpack config, both are really big.

current error I have is:

WARN Force closed manager build
ModuleParseError: Module parse failed: Assigning to rvalue (1:1)
You may need an appropriate loader to handle this file type, currently no loaders are configured to process this file. See https://webpack.js.org/concepts#loaders
> [data-theme=light]{--coral-color-neutral-text: hsla(0, 0%, 13%, 1);
keyframes coral-dark-keyframes-blink{0%,100%{opacity:1}50%{opacity:.5}}
| 
| /*# sourceMappingURL=TalendDesignTokens.css.map*/
    at handleParseError (/home/jean/github/talend/ui-ee/node_modules/webpack/lib/NormalModule.js:976:19)
    at /home/jean/github/talend/ui-ee/node_modules/webpack/lib/NormalModule.js:1095:5
    at processResult (/home/jean/github/talend/ui-ee/node_modules/webpack/lib/NormalModule.js:800:11)
    at /home/jean/github/talend/ui-ee/node_modules/webpack/lib/NormalModule.js:860:5

image

What is the chosen solution to this problem?

simplification: just remove few conflicting rules from storybook webpack and add our rules.

Note: we are discussing of incoming simplification which will have side effect to remove this need:

  • use .module.scss syntax to active css module
  • remove the auto import of bootstrap scss variables

both will be breaking changes

Please check if the PR fulfills these requirements

  • [x] The PR have used yarn changeset to a request a release from the CI if wanted.
  • [x] The PR commit message follows our guidelines
  • [x] Tests for the changes have been added (for bug fixes / features) And non reg done before need review
  • [x] Docs have been added / updated (for bug fixes / features)
  • [ ] Related design / discussions / pages (not in jira), if any, are all linked or available in the PR

[ ] This PR introduces a breaking change

jmfrancois avatar Jul 08 '22 09:07 jmfrancois

Size Change: 0 B

Total Size: 12.7 MB

ℹ️ View Unchanged
Filename Size Change
./packages/assets-api/dist/TalendAssetsApi.js 7.35 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.js.dependencies.json 2 B 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js 3.4 kB 0 B
./packages/assets-api/dist/TalendAssetsApi.min.js.dependencies.json 2 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js 39.7 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.js.dependencies.json 604 B 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js 6.94 kB 0 B
./packages/cmf-cqrs/dist/TalendReactCmfCqrs.min.js.dependencies.json 623 B 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js 121 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.js.dependencies.json 1.27 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js 12.5 kB 0 B
./packages/cmf-router/dist/TalendReactCmfRouter.min.js.dependencies.json 1.31 kB 0 B
./packages/cmf/dist/TalendReactCmf.js 537 kB 0 B
./packages/cmf/dist/TalendReactCmf.js.dependencies.json 1.33 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js 106 kB 0 B
./packages/cmf/dist/TalendReactCmf.min.js.dependencies.json 1.37 kB 0 B
./packages/components/dist/TalendReactComponents.css 182 kB 0 B
./packages/components/dist/TalendReactComponents.js 3.48 MB 0 B
./packages/components/dist/TalendReactComponents.js.dependencies.json 3.15 kB 0 B
./packages/components/dist/TalendReactComponents.min.js 633 kB 0 B
./packages/components/dist/TalendReactComponents.min.js.dependencies.json 3.22 kB 0 B
./packages/containers/dist/TalendReactContainers.css 1.73 kB 0 B
./packages/containers/dist/TalendReactContainers.js 449 kB 0 B
./packages/containers/dist/TalendReactContainers.js.dependencies.json 1.56 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js 88.8 kB 0 B
./packages/containers/dist/TalendReactContainers.min.js.dependencies.json 1.6 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.css 6.82 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.js 233 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.js.dependencies.json 1.38 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.min.js 42.9 kB 0 B
./packages/datagrid/dist/TalendReactDatagrid.min.js.dependencies.json 1.42 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.css 8.72 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js 381 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.js.dependencies.json 1.16 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js 61.3 kB 0 B
./packages/dataviz/dist/TalendReactDataviz.min.js.dependencies.json 1.19 kB 0 B
./packages/design-system/dist/TalendDesignSystem.css 89.7 kB 0 B
./packages/design-system/dist/TalendDesignSystem.js 1.36 MB 0 B
./packages/design-system/dist/TalendDesignSystem.js.dependencies.json 1.57 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js 231 kB 0 B
./packages/design-system/dist/TalendDesignSystem.min.js.dependencies.json 1.61 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.css 36.2 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js 86 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.js.dependencies.json 2 B 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js 28.4 kB 0 B
./packages/design-tokens/dist/TalendDesignTokens.min.js.dependencies.json 2 B 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.css 15 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js 434 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.js.dependencies.json 1.55 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js 94.2 kB 0 B
./packages/faceted-search/dist/TalendReactFacetedSearch.min.js.dependencies.json 1.59 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js 49.5 kB 0 B
./packages/flow-designer/dist/TalendReactFlowDesigner.min.js.dependencies.json 1.08 kB 0 B
./packages/forms/dist/mode-json.js 48.3 kB 0 B
./packages/forms/dist/mode-python.js 4.61 kB 0 B
./packages/forms/dist/mode-sql.js 1.83 kB 0 B
./packages/forms/dist/snippets-json.js 131 B 0 B
./packages/forms/dist/snippets-python.js 3.84 kB 0 B
./packages/forms/dist/snippets-sql.js 972 B 0 B
./packages/forms/dist/TalendReactForms.css 11.7 kB 0 B
./packages/forms/dist/TalendReactForms.js 822 kB 0 B
./packages/forms/dist/TalendReactForms.js.dependencies.json 1.66 kB 0 B
./packages/forms/dist/TalendReactForms.min.js 210 kB 0 B
./packages/forms/dist/TalendReactForms.min.js.dependencies.json 1.7 kB 0 B
./packages/forms/dist/theme-chrome.js 2.71 kB 0 B
./packages/http/dist/TalendHttp.js 23.1 kB 0 B
./packages/http/dist/TalendHttp.js.dependencies.json 2 B 0 B
./packages/http/dist/TalendHttp.min.js 3.98 kB 0 B
./packages/http/dist/TalendHttp.min.js.dependencies.json 2 B 0 B
./packages/icons/dist/bundle.js 1.26 kB 0 B
./packages/icons/dist/info.js 24.6 kB 0 B
./packages/icons/dist/react.esm.js 531 kB 0 B
./packages/icons/dist/react.js 571 kB 0 B
./packages/icons/dist/talend-icons-webfont.css 16.8 kB 0 B
./packages/icons/dist/talendicons.css 334 B 0 B
./packages/icons/dist/TalendIcons.js 643 kB 0 B
./packages/icons/dist/TalendIcons.js.dependencies.json 128 B 0 B
./packages/icons/dist/TalendIcons.min.js 554 kB 0 B
./packages/icons/dist/TalendIcons.min.js.dependencies.json 131 B 0 B
./packages/icons/dist/typeUtils.js 13.3 kB 0 B
./packages/jsfc/dist/index.js 86.4 kB 0 B
./packages/jsfc/dist/index.js.dependencies.json 2 B 0 B
./packages/router-bridge/dist/TalendRouterBridge.js 92.2 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.js.dependencies.json 1.05 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js 20.6 kB 0 B
./packages/router-bridge/dist/TalendRouterBridge.min.js.dependencies.json 1.07 kB 0 B
./packages/sagas/dist/TalendReactSagas.js 10.9 kB 0 B
./packages/sagas/dist/TalendReactSagas.js.dependencies.json 348 B 0 B
./packages/sagas/dist/TalendReactSagas.min.js 1.41 kB 0 B
./packages/sagas/dist/TalendReactSagas.min.js.dependencies.json 360 B 0 B
./packages/stepper/dist/TalendReactStepper.js 24.4 kB 0 B
./packages/stepper/dist/TalendReactStepper.js.dependencies.json 962 B 0 B
./packages/stepper/dist/TalendReactStepper.min.js 4.05 kB 0 B
./packages/stepper/dist/TalendReactStepper.min.js.dependencies.json 984 B 0 B
./packages/storybook-docs/dist/globalStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/globalStyles.min.css 9.15 kB 0 B
./packages/storybook-docs/dist/managerStyles.js 0 B 0 B 🆕
./packages/storybook-docs/dist/managerStyles.min.css 1.53 kB 0 B
./packages/theme/dist/bootstrap.css 149 kB 0 B
./packages/theme/dist/bootstrap.js 2.51 kB 0 B
./packages/theme/dist/bootstrap.js.dependencies.json 3 B 0 B

compressed-size-action

github-actions[bot] avatar Jul 08 '22 09:07 github-actions[bot]

4199

:octocat: Demo is available here

github-actions[bot] avatar Jul 08 '22 09:07 github-actions[bot]

use .module.scss syntax to active css module

YES

Benrajalu avatar Jul 08 '22 10:07 Benrajalu