Tal500

Results 152 comments of Tal500

> I prefer that you add some pytest test file to simplecpp repo. We want to test this directly here. Will do that, I need also to copy some verification...

> I prefer that you add some pytest test file to simplecpp repo. We want to test this directly here. > > I don't have strong opinion. But you could...

> Thanks.. test looks good imho. I have two more small comments: > > * I would like that there is an issue for this. > > * please run...

> sorry for delayed review. please refactor testing. Done

> To dedupe `.originalText`, it will need to process all css files at once because it needs to know depency graph. Is this hard to do with Vite plugins architecture?...

> @Tal500 Please simplify this issue description. Please just show relevant `gcc -E` output. I updated this issue now to contain simpler reproduction.

> I don't know.. this might be related to #397 I can confirm that the problem remains even though #397 was fixed.

Looking on the code of simplecpp, the root cause of this issue as far as I can, is that simplecpp resolves function-like macros in a recursive way, instead of by...

> [@Tal500](https://github.com/Tal500) I did not see such information when I started implementing simplecpp and therefore I implemented the macro expansion using trial and error. So it wasn't that I _wanted_...

> @Tal500 can you please simplify the examples. The code `int foo() {` is not handled during the preprocessing and can be removed. I prefer if you just show the...