Watson icon indicating copy to clipboard operation
Watson copied to clipboard

Added started project time to aggregate and report

Open Spiegie opened this issue 2 years ago • 5 comments

  • added new flag (-i) to ignore started Project
  • added ignore_current as parameter to functions
  • changed behavior of report function to add started project time

It bothered me, that my current started Project does not count to the Time displayed for "watson report" and "watson aggregate"

That is my first contribution to a project. Please be gentle, if I did something not the right way

Spiegie avatar Mar 10 '22 16:03 Spiegie

Please tell me, if I need to update the Docs for this change. If so, I will do my best to do that.

Spiegie avatar Mar 10 '22 16:03 Spiegie

Hi @Spiegie :wave:

Thank you for implementing this :pray: Can you add tests to this PR? Thx again!

jmaupetit avatar Mar 11 '22 09:03 jmaupetit

Thank you for your Feedback @jmaupetit . I am not experienced with tests, but I will learn it. As long, I don't have implemented the Test, I will mark this PR as WIP

Spiegie avatar Mar 11 '22 09:03 Spiegie

No problem with that, take a look at already implemented tests. Take your time. :pray:

jmaupetit avatar Mar 11 '22 10:03 jmaupetit

Finally, I found some time to learn about tests. I hope the Tests, I added, are enough. Please tell me, if I should do more.

Spiegie avatar Apr 14 '22 09:04 Spiegie

im closing this PR It tourned out, the changes have some Issues. I dont have the time to fix it.

Spiegie avatar Nov 18 '22 17:11 Spiegie