TagStudio icon indicating copy to clipboard operation
TagStudio copied to clipboard

[Bug]: Editing things from a closed library

Open SkeleyM opened this issue 10 months ago • 3 comments

Checklist

  • [x] I have read the documentation.
  • [x] I am using an up-to-date version.
  • [x] I have searched existing issues.

TagStudio Version

Alpha 9.5.0 (Pre-Release 1)

Operating System & Version

Windows 10 22H2

Description

Closing a library doesn't 'fully' close it you can still edit tags, create new ones, etc from the previously opened library

Expected Behavior

You shouldnt be able to modify the previous library if you close a library

Steps to Reproduce

  1. Open a library
  2. close it: file -> close library
  3. open manage tags

Logs

No response

SkeleyM avatar Feb 01 '25 23:02 SkeleyM

the issue seems to be that the engine is not properly cleaned up on closing a library theres two approaches that I can see and one is setting engine to None, which causes a whole bunch of errors (all recoverable) or explicitly deleting the engine which causes it to be in the same state as when the program starts. I think the latter is preferable since then there is consistency. I can submit a pull request for either. I already have tried both so it would be quick for me to do (both one line changes) I'd just like some input on which would be preferable or if theres any other solutions to this that I cant see

SkeleyM avatar Feb 01 '25 23:02 SkeleyM

While I'm not able to foresee any potential issues off the top of my head, it seems like your second proposed solution is the better choice 👍

CyanVoxel avatar Feb 02 '25 00:02 CyanVoxel

Lowering the priority of this and #769 now that #787 has been merged

CyanVoxel avatar Feb 05 '25 00:02 CyanVoxel

As of #787 the tag manager can't be opened anymore when the library is closed

Computerdores avatar Jun 04 '25 17:06 Computerdores