TagStudio icon indicating copy to clipboard operation
TagStudio copied to clipboard

Add Location Fields

Open Nginearing opened this issue 1 year ago • 9 comments

  • Add location (text line) fields

Nginearing avatar Oct 09 '24 22:10 Nginearing

Sorry, I'm stupid lol. I thought that CyanVoxel said about making a pull request or something to the 9.4 branch instead, I should I switch this to the main branch? (and obviously sync my branch to match the main branch, before doing so) ?

Nginearing avatar Oct 09 '24 22:10 Nginearing

Yes, per 332 merge Discord announcement Unless this qualifies as a "teeny tiny QoL feature", but IMO while small doesn't qualify and I don't know if another 9.4 release is planned

seakrueger avatar Oct 09 '24 22:10 seakrueger

The json library is no longer used on main, new fields should be added under library/alchemy/fields.py

seakrueger avatar Oct 09 '24 23:10 seakrueger

The json library is no longer used on main, new fields should be added under library/alchemy/fields.py

Of course, I just clicked through the folders, I didn't even look at the folder names, oops.

Nginearing avatar Oct 09 '24 23:10 Nginearing

I think that's correct now.

Nginearing avatar Oct 09 '24 23:10 Nginearing

This is indeed the correct branch for new features at the moment.

While location fields would be beneficial (as we chatted about a few weeks ago) I think the field would make more sense to hold actual EXIF-style GPS location data rather than just be a cosmetic text field. Custom names for fields are coming in the future too, so there wouldn't be a need for hardcoded names for fields such as this when that eventually lands.

CyanVoxel avatar Oct 10 '24 19:10 CyanVoxel

This is indeed the correct branch for new features at the moment.

While location fields would be beneficial (as we chatted about a few weeks ago) I think the field would make more sense to hold actual EXIF-style GPS location data rather than just be a cosmetic text field. Custom names for fields are coming in the future too, so there wouldn't be a need for hardcoded names for fields such as this when that eventually lands.

How about: TagStudio shows location (gps) metadata alongside the usual Date Created and Date Modified metadata, what you're describing, sounds similar to the ability to modify metadata which afaik has been mentioned in an issue before.

Nginearing avatar Oct 10 '24 20:10 Nginearing

How about: TagStudio shows location (gps) metadata alongside the usual Date Created and Date Modified metadata, what you're describing, sounds similar to the ability to modify metadata which afaik has been mentioned in an issue before.

This is something I would like also like, along with showing any other EXIF data in a similar manner. This PR/feature request would more so be for adding custom GPS/location data for your own purposes and/or having multiple GPS values per file entry. As I think about it though, I'm struggling to come up with practical use cases for this... If @Nginearing is okay with just having the EXIF data display with the potential for EXIF editing further down the line, then I'm okay with that too.

CyanVoxel avatar Oct 11 '24 02:10 CyanVoxel

I'll get started on programming the implementation to show the gps coordinates exif data.

Nginearing avatar Oct 11 '24 13:10 Nginearing