TagStudio icon indicating copy to clipboard operation
TagStudio copied to clipboard

Translations

Open Tyrannicodin opened this issue 1 year ago • 6 comments

Adds a translator that handles translation of objects via QCoreApplication.translate(context, key), and translations are stored as .ini files in the format: *context*.*key*="*Translation*"

Currently has very few actually translated components, just the structure to add more.

Tyrannicodin avatar Sep 04 '24 21:09 Tyrannicodin

Now that #332 has merged, this would be a great time to start separating out the strings to try using with Weblate

CyanVoxel avatar Sep 10 '24 08:09 CyanVoxel

Strings separated in #507 I guess the best course of action would either be to:

  • Merge this PR, then #507
  • Add the json of strings to this PR.

Any thoughts?

@Tyrannicodin how much is left for this to be a proper PR and not a draft?

Bamowen avatar Sep 17 '24 13:09 Bamowen

@Tyrannicodin how much is left for this to be a proper PR and not a draft?

The only missing thing is replacing all strings with translation functions, which I want to do in this pr or else it won't really add much.

Tyrannicodin avatar Sep 17 '24 13:09 Tyrannicodin

en.json Here you go!

Bamowen avatar Sep 17 '24 14:09 Bamowen

Hmm, I'm not sure we need to translate logs right? They're not user-facing after all.

Tyrannicodin avatar Sep 18 '24 15:09 Tyrannicodin

Definitely lower priority, but I'm in favor of translating everything.

Completely fine with just removing them as you see fit. I do not have enough knowledge of the code base (or code in general for that matter) to decide for myself what is user facing and what's not

Bamowen avatar Sep 18 '24 16:09 Bamowen

Just wanted to bump this and check if this is still being worked on. Translations are being pulled from webplate, so the sooner we can implement those, the better. Thanks!

seakrueger avatar Nov 15 '24 21:11 seakrueger