TagStudio icon indicating copy to clipboard operation
TagStudio copied to clipboard

feat(qt): Add hotkey to add tags to selection

Open dtomvan opened this issue 1 year ago • 4 comments

This is used so that you don't have to go through the mouse-heavy nitty-gritty of:

  1. Select one or more files
  2. Add field
  3. Tags
  4. OK
  5. Add Tag
  6. Click on the plus sign
  7. Done

To get to a tag selection modal. This reduces a lot of friction in my opinion. I like the way that the fields can have multiple types, but in the majority of cases I just want to quickly tag one or more files in my selection and move on. The workflow after this change is as follows:

  1. Select one or more files
  2. Just press Ctrl+Shift+T
  3. Click on the plus sign
  4. Done

This way the tagbox gets added automatically (through the powerful core library system) and you can immediately start tagging!

dtomvan avatar Jun 28 '24 11:06 dtomvan

I agree with your proposed changes, however, I think that those issues should be fixed in one fell swoop as per a refactor changeset. I don't think that should be included in a feature PR. Do as you want though; maybe I'll look at the refactoring I could do later on.

dtomvan avatar Jul 05 '24 08:07 dtomvan

To add to that: I've written my PR consciously in this way, as to stay consistent with the existing code. I know that constitutes "copy-paste code", but I thought it was appropriate here.

dtomvan avatar Jul 05 '24 08:07 dtomvan

Yeah i thougt that and you are probably right that the refactoring part is better of in another pr.

Thesacraft avatar Jul 05 '24 10:07 Thesacraft

Unfortunately this is going to need some refactoring to work with the new SQL backend (#332). I understand this PR has been open for a while now, and I apologize for taking a while to get around to it.

The merge conflict here is pretty minor, and from what I can tell the FieldID has changed places and is imported as FieldID_ now. The self.selected list is now consists solely of Entry ID ints so it simplifies some of the logic there. Finally the logic for adding Tags to Entries themselves has changed, and this is something I need to become more familiar with myself before giving instructions on how it currently operates.

I love the idea of this feature, and it brings things one step closer to being fully keyboard controlled. My only gripe is that there's no way to choose which type of Tag Field the tag gets added to. Personally I use "Meta Tags" and "Content Tags" in my library, so I would effectively be locked out of using such a great shortcut. I'm also obligated to mention that the entire "Tag Fields" concept will eventually be replaced by automatic tag categories in a future update, so issues like this will no longer be a concern.

CyanVoxel avatar Sep 10 '24 09:09 CyanVoxel

Made obsolete by #655 which removed tag fields in favor of applying tags directly to entries and then automatically sorting them by category

CyanVoxel avatar Jan 13 '25 23:01 CyanVoxel

Oops, haven't looked back at this PR for a while now. Good to hear things are better overall for the software. Apologies accepted 😂

dtomvan avatar Jan 21 '25 21:01 dtomvan