TabularEditor3 icon indicating copy to clipboard operation
TabularEditor3 copied to clipboard

Formatting Discrepancies between DAXFormatter.com service and internal formatter

Open edhans opened this issue 1 year ago • 1 comments

Describe the issue I use the Short Line preference for both the service and the built in formatter, and there are a number of places the built in formatter puts extra breaks, especially before operators, that I think are unnecessary and IMHO make the code harder to read. See the two images. The top image is from the internal formatter, the bottom from the service.

Overall:

  • varCurrentYYYMM is 3 lines vs 1. If a function has one option, it should be one line. It should only break a function into multiple lines if it has 2+ options.
  • var6MonthsAgo is 1 line vs 4. I am ok with 1, but 4 seems consistent with breaking after each comma and having the options on separate lines when there is more than 1. I could be persuaded that 2 options are fine to put on one line though, especially when the 2nd option is an integer or some other constant.
  • var6MonthsAgoYYYYMM is 5 lines vs 4. I think it is unnecessary to break at the equals sign, and harder to read.
  • var6MonthsRange is 8 lines vs 6 - again unnecessary breaks at the operators

image image

** Which version are you currently using? ** Tabular 3.9 Enterprise

Power BI Service and Desktop

My DAX Editor preferences, only checking or unchecking the "Use daxformatter.com" box between the taking of those images. image

edhans avatar Jul 24 '23 16:07 edhans

Hi @edhans

Added a bug to the backlog so we can get a better match with daxformatter.com. Again, thanks for reporting.

Best Regards

David - Tabular Editor 3 Support

DBojsen avatar Aug 03 '23 09:08 DBojsen