TabularEditor3 icon indicating copy to clipboard operation
TabularEditor3 copied to clipboard

Tables removed from diagrams automatically don't show the diagrams file as dirty and needing to be saved

Open edhans opened this issue 1 year ago • 3 comments

Describe the issue If you remove a table from the model and then later open a diagram that had that table in it, you get a notice that Table X is no longer in the model and was removed from the diagram.

However, the diagram is not flagged as dirty so if you close it, it won't ask you to save changes and then will repeat the warning the next time you open it. You must manually save it after that warning pops up.

** Which version are you currently using? ** Tabular Editor 3, version: 3.8 Tabular Editor 3 edition: Enterprise

To Reproduce Power BI service connection

Steps to reproduce the behavior:

  1. add a table to a diagram and save it. Close the diagram.
  2. remove the table from the model.
  3. Open the diagram. You'll be told it has been removed.
  4. Close the diagram. Notice there is no Save confirmation?
  5. Open the diagram. It will repeat at step #3 above.

Expected behavior The diagram should be flagged as being changed, and when you close it it will ask for a confirmation to save.

edhans avatar Jul 07 '23 22:07 edhans

Related - if you create a new DAX Script by selecting measures or other objects in the TOM, that DAX Script isn't flagged as dirty so you can close without being asked to save, or if you close TE itself, you will just lose those windows.

edhans avatar Jul 11 '23 22:07 edhans

if you create a new DAX Script by selecting measures or other objects in the TOM, that DAX Script isn't flagged as dirty so you can close without being asked to save, or if you close TE itself, you will just lose those windows.

This is actually by design, since you haven’t made any changes to the script at this point, there’s no point in asking you to save it. Or maybe I’m missing something?

otykier avatar Jul 12 '23 07:07 otykier

Ahh. Yes. I Script measures before I delete them and the save the script in case I want to refer to them later or add them back. If I close that tab before saving I lose my “backup.”

edhans avatar Jul 12 '23 11:07 edhans