tabby icon indicating copy to clipboard operation
tabby copied to clipboard

VSCode Extension's current inline edit always prompts a blank line under the header.

Open Sma1lboy opened this issue 1 year ago • 2 comments

Please describe the feature you want Every time I try to use inline edit, I find that a blank line appears in the new edited area. This affects the quality of the inline edit in some cases, especially for dense lines of code.

https://github.com/user-attachments/assets/db7738b9-04ec-49db-8439-e4e434d37d8d


Please reply with a 👍 if you want this feature.

Sma1lboy avatar Oct 17 '24 06:10 Sma1lboy

the generate docs command generated one more \n

here is my debug output:

[inline-ediet] edit.editedText: \\nimport { window, LogOutputChannel } from \"vscode\";\\n

[inline-ediet] edit.originalText: import { window, LogOutputChannel } from \"vscode\";\\n

Sma1lboy avatar Oct 17 '24 07:10 Sma1lboy

Follow up:

After careful consideration from multiple perspectives, we have decided not to proceed with this change for now. We observed that blank line behavior varies depending on user input commands and default prompts. Our current strategy is to avoid enforcing this through rules or fixing it by diffing original code against generated code. In one scenario, users may consent to LLM inline edits that directly add extra blank lines. There is significant overlap between different cases. Therefore, this issue is currently on hold.

Sma1lboy avatar Oct 24 '24 03:10 Sma1lboy