tabby icon indicating copy to clipboard operation
tabby copied to clipboard

build(tabby): disable debug symbols for dependencies

Open boxbeam opened this issue 1 year ago • 4 comments

My build caches have been getting quite large, so I figured it might make sense to add this setting to disable debug symbols in dependency crates, since they will basically never be used. This reduces cache size by ~34%

boxbeam avatar Jun 11 '24 21:06 boxbeam

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.30%. Comparing base (06e0754) to head (3d8bfc1). Report is 10 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2391   +/-   ##
=======================================
  Coverage   57.29%   57.30%           
=======================================
  Files         164      164           
  Lines       14644    14659   +15     
=======================================
+ Hits         8391     8400    +9     
- Misses       6253     6259    +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 11 '24 21:06 codecov[bot]

I'm still hesitating to disable all of them, some of external dependencies are still helpful to locates crashes / profiling, e.g tantivy.

Is there a way to create a white list?

wsxiaoys avatar Jun 12 '24 02:06 wsxiaoys

Yes, we could do profile.dev.package.<name>.debug = 0 for each one we want to disable, though that might end up being a huge number of lines since we have ~700 dependencies and each individual line would probably make very little difference

boxbeam avatar Jun 12 '24 03:06 boxbeam

Okay, looking more closely it seems like we actually can leave in the * rule and still enable debug symbols for individual dependencies, which is much better

boxbeam avatar Jun 12 '24 18:06 boxbeam