tailor
tailor copied to clipboard
[TASK] Prioritize composer.json over environment variable for extension key
Summary
This PR changes the extension key resolution order to prioritize composer.json over the TYPO3_EXTENSION_KEY environment variable.
New precedence:
- CLI argument (highest priority)
-
composer.jsonat[extra][typo3/cms][extension-key](recommended) -
TYPO3_EXTENSION_KEYenvironment variable (deprecated, BC only)
Changes
- CommandHelper.php: Reordered resolution logic, added deprecation warning when using env var
- README.md: Updated documentation and CI examples to reflect new approach
-
.env.dist: Removed
TYPO3_EXTENSION_KEY(new setups should use composer.json) - Tests: Updated to verify deprecation warning is triggered
Why?
-
Single source of truth: Extension key belongs in
composer.jsonalongside other extension metadata -
CI log masking issue: When
TYPO3_EXTENSION_KEYis configured as a secret, error messages get masked (e.g."Could not publish extension ***"), hiding valuable information in error reports
Backwards Compatibility
The environment variable still works for existing setups but triggers a deprecation warning encouraging migration to composer.json.
Resolves: #88