Fluid icon indicating copy to clipboard operation
Fluid copied to clipboard

[BUGFIX] Fix contentAs feature when used on Layout level

Open smichaelsen opened this issue 4 years ago • 5 comments

<f:render section="MySection" contentAs="content">some content</f:section> does not work when called from a Layout because the content variable is not passed to the section in that case.

smichaelsen avatar Jul 31 '19 12:07 smichaelsen

Coverage Status

Coverage decreased (-0.07%) to 97.091% when pulling 68db27f83e55fcd4bf1c986f8a52b2fb86768746 on smichaelsen:contentas-in-layout into ae2d3d7ac201046275418c876fb82b63759678b1 on TYPO3:master.

coveralls avatar Jul 31 '19 13:07 coveralls

Thanks for the report and fix. Would you be able to add a functional test case for this? You can have a look at the existing tests.

mbrodala avatar Jul 31 '19 13:07 mbrodala

Thanks for your feedback, Mathias. I fear I can't add a test at the moment (deadlines and stuff). Would that block my PR from being merged?

smichaelsen avatar Jul 31 '19 13:07 smichaelsen

Of course not. I'll have a look at this.

mbrodala avatar Jul 31 '19 13:07 mbrodala

@NamelessCoder I've added a test for this now which looks basically correct but still fails. Can you have a look?

mbrodala avatar Jul 31 '19 13:07 mbrodala