ext-solr icon indicating copy to clipboard operation
ext-solr copied to clipboard

[BUG] plugin.tx_solr_PiSearch_Search does not use sitepackage fluid partial Form.html

Open srchild opened this issue 5 months ago • 0 comments

Describe the bug Overriding Partials/Search/Form.html in sitepackage does not change the searchbox code inserted by lib.searchbox < plugin.tx_solr_PiSearch_Search.

It does change the code of searchbox on the results page, but does not change the code of the mini-searchboxes inserted with the plugin

To Reproduce Steps to reproduce the behavior:

  1. Notice that Pagespeed complains of lack of labels for the searchbox button and input control on the searchbox inserted with <f:cObject typoscriptObjectPath="lib.searchbox" />
  2. Edit Partials/Search/Form.html to add appropriate aria-labels
  3. Inspect the site and notice that the new labels appear as expected on the searchbox on the results page but not on the mini-search box inserted on every other page using <f:cObject typoscriptObjectPath="lib.searchbox" />
  4. I can only make the labels show on the mini-searchbox by editing the original fluid partial Form.html within EXT:solr/Resources/Private

Expected behavior I expected that adding the labels to my sitepackage copy of the fluid partial Form.html for the search code would add the labels to all instances of the search code. I did not expect to have to edit the original files in the solr extension (which will of course be overwritten when the extension is updated)

Screenshots

Used versions (please complete the following information):

  • TYPO3 Version: [12.4.34]
  • Browser: [Chrome]
  • EXT:solr Version: [12.0.7]
  • Used Apache Solr Version: [typo3solr/ext-solr:latest Docker]
  • PHP Version: [8.1.33]
  • MySQL Version: [MariaDB 10.6.22]

Additional context It appears that lib.solr_extbase_bootstrap is being initialised with the original values of view instead of the overridden values

srchild avatar Aug 11 '25 21:08 srchild