ext-solr icon indicating copy to clipboard operation
ext-solr copied to clipboard

[TASK] Do not ignore database exceptions

Open christophlehmann opened this issue 1 year ago • 1 comments

What this pr does

This removes a try catch block around a select query.

When a database query is not okay for any reason, then i like to get the reason directly.

Fixes: #4199

christophlehmann avatar Oct 24 '24 16:10 christophlehmann

I agree that muted exceptions are a no-go, but IMHO a proper handling is much better than letting the application break with an unhandled exception. And there are already enough of completely unhelpful stack traces in logs created by Solr.

I suggest at least logging the SQL statement and the context in some readable manner before letting the calling code choke on the exception.

masi avatar Nov 04 '24 12:11 masi