ext-solr icon indicating copy to clipboard operation
ext-solr copied to clipboard

BUG [4026] treat non-overlayed mount points as valid

Open derMatze82 opened this issue 9 months ago • 4 comments

What this pr does

Allows non-overlayed mount points to be valid

How to test

Please add a testing instruction here

Fixes: #issue 4026

derMatze82 avatar May 08 '24 11:05 derMatze82

@derMatze82 Please check the tests suite. The CI fails.

dkd-kaehm avatar May 13 '24 06:05 dkd-kaehm

@dkd-kaehm sorry I can't get the integration tests running locally:

PHPUnit 10.5.20 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.6 with PCOV 1.0.11
Configuration: /home/Development/ext-solr_4026/Build/Test/IntegrationTests.xml
1) ApacheSolrForTypo3\Solr\Tests\Integration\IndexQueue\Initializer\PageTest::initializerIsFillingQueueWithMountPages
PHPUnit\Framework\Exception: PHP Fatal error:  Uncaught PHPUnit\Event\Code\NoTestCaseObjectOnCallStackException: Cannot find TestCase object on call stack in /home/Development/ext-solr_4026/.Build/vendor/phpunit/phpunit/src/Event/Value/Test/TestMethodBuilder.php:63
Stack trace:
#0 /home/Development/ext-solr_4026/.Build/vendor/phpunit/phpunit/src/Runner/ErrorHandler.php(64): PHPUnit\Event\Code\TestMethodBuilder::fromCallStack()
#1 [internal function]: PHPUnit\Runner\ErrorHandler->__invoke()
#2 Standard input code(71): rewind()
#3 Standard input code(118): __phpunit_run_isolated_test()
#4 {main}
  thrown in /home/Development/ext-solr_4026/.Build/vendor/phpunit/phpunit/src/Event/Value/Test/TestMethodBuilder.php on line 63

derMatze82 avatar May 13 '24 10:05 derMatze82

@dkd-kaehm sorry I can't get the integration tests running locally:

PHPUnit 10.5.20 by Sebastian Bergmann and contributors.

Runtime:       PHP 8.3.6 with PCOV 1.0.11
Configuration: /home/Development/ext-solr_4026/Build/Test/IntegrationTests.xml
1) ApacheSolrForTypo3\Solr\Tests\Integration\IndexQueue\Initializer\PageTest::initializerIsFillingQueueWithMountPages
PHPUnit\Framework\Exception: PHP Fatal error:  Uncaught PHPUnit\Event\Code\NoTestCaseObjectOnCallStackException: Cannot find TestCase object on call stack in /home/Development/ext-solr_4026/.Build/vendor/phpunit/phpunit/src/Event/Value/Test/TestMethodBuilder.php:63
Stack trace:
#0 /home/Development/ext-solr_4026/.Build/vendor/phpunit/phpunit/src/Runner/ErrorHandler.php(64): PHPUnit\Event\Code\TestMethodBuilder::fromCallStack()
#1 [internal function]: PHPUnit\Runner\ErrorHandler->__invoke()
#2 Standard input code(71): rewind()
#3 Standard input code(118): __phpunit_run_isolated_test()
#4 {main}
  thrown in /home/Development/ext-solr_4026/.Build/vendor/phpunit/phpunit/src/Event/Value/Test/TestMethodBuilder.php on line 63

Please checkout our environment: https://github.com/TYPO3-Solr/solr-ddev-site

dkd-kaehm avatar May 13 '24 11:05 dkd-kaehm

Please do not use git merge within "TYPO3-Solr/ext-" repositories, the pull-requests are not mergable, because of linear-history constrain. Use always git rebase instead. I fixed currently you PR branch and target to release-12.0.x, please use git reset --hard <your-remote>/main

Our main branch is currently for TYPO3 13 and not ready for CI, therefore use release-12.0.x as source and target for rebases and PRs.

dkd-kaehm avatar May 13 '24 13:05 dkd-kaehm