ext-solr icon indicating copy to clipboard operation
ext-solr copied to clipboard

[BUG:solrfal] Error message shown on initialization, if "attachments" disabled for some queue configuration

Open RazielleS opened this issue 1 year ago • 7 comments

Describe the bug When initializing the solr queue of custom records, I get the error 1662117020. This seems to happen because solrfal is installed. Solrfal has an event listener AfterIndexQueueHasBeenInitialized which looks for files to index. If the attachments config is not set, or no file is found in all records, it will not set the queue to initialized, thus this error is shown.

To Reproduce Steps to reproduce the behavior:

  1. Initialize queue of a custom record
  2. See the error

Expected behavior The error should either explain what went wrong, or should not be shown at all.

Used versions (please complete the following information):

  • TYPO3 Version: 12.4.7
  • Browser: Firefox
  • EXT:solr Version: 12.0.0
  • EXT:solrfal Version 12.0.0
  • Used Apache Solr Version: typo3solr/ext-solr:12.0.x-dev
  • PHP Version: 8.2.12
  • MariaDB Version: 10.5.22

Maintainers notes

This is just a GUI bug. The initialization of queues succeeds without any troubles.

Bildschirmfoto vom 2023-11-02 19-42-28

The source is c2e84f9445173e55ee285a27613cf4940eda32c1. So we want to collect and delegate to GUI a little bit more infos from ...\Event\IndexQueue\AfterIndexQueueHasBeenInitializedEvent as just the bool. The decision to show the error or not, can not be precise enough.

RazielleS avatar Oct 30 '23 10:10 RazielleS

We'll fix it with temporary fix on EXT:solrfal

dkd-kaehm avatar Feb 14 '24 11:02 dkd-kaehm

When any progress on this?

Zillion01 avatar Apr 25 '24 07:04 Zillion01

Any estimate /progress on this issue?

support-beech avatar Apr 25 '24 08:04 support-beech

We just released solrfal 12.0.1, issue is fixed in that version.

dkd-friedrich avatar May 13 '24 06:05 dkd-friedrich

I don't think that this is fixed @dkd-friedrich We use 12.0.1 and we still get the error for e.g. news where there are no files found in these records and therefore are no extracted queue items found/generated. \ApacheSolrForTypo3\Solrfal\Detection\RecordContextDetector::initializeQueueForConfiguration returns 0 and this leads to the mentioned error above (even if it's not an error at all, if I've understood correctly). Please give me some feedback what you think. We are paying customers.

wazum avatar Jul 22 '24 15:07 wazum

@wazum Thanks for the hint, you are right. The fix in solrfal 12.0.1 concentrated too much on the initialisation of the queues with deactivated contexts. The fact that the status is not correct if no files are found in the RecordContext was overlooked.

We are currently working on solrfal 12.0.2, I am trying to include an extended bugfix there.

dkd-friedrich avatar Jul 23 '24 12:07 dkd-friedrich

@wazum We have just released solrfal 12.0.2, which addresses the problem. Please update, your feedback on the new version will be welcome.

dkd-friedrich avatar Jul 25 '24 12:07 dkd-friedrich