headless icon indicating copy to clipboard operation
headless copied to clipboard

Published 20 hours ago • verified publisher icon TYPO3-Headless

[BUGFIX] Fix crash when link is not resolved properly

Open twoldanski opened this issue 2 years ago • 4 comments

Typolink method return empty string when it can not resolve link parameter

twoldanski avatar Dec 05 '22 09:12 twoldanski

Pull Request Test Coverage Report for Build 3823384068

  • 1 of 1 (100.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 60.339%
Totals Coverage Status
Change from base Build 3823382111: 0.0%
Covered Lines: 677
Relevant Lines: 1122
💛 - Coveralls

coveralls avatar Dec 05 '22 09:12 coveralls

for version 12 we should use LinkFactory here, don't we?https://github.com/TYPO3/typo3/commit/4f7c4d1cc240071b38144e8f1d42cc62cdaedbe6 maybe add a todo in code or create an issue, what do you think @twoldanski ?

tmotyl avatar Dec 05 '22 11:12 tmotyl

please also add a test case for this issue

tmotyl avatar Dec 05 '22 11:12 tmotyl

@tmotyl yeah for branch 4.x / T3 v12 we should use LinkFactory, also this class needs some cleanup on 4.x branch I added quick test for it in 3.x

twoldanski avatar Dec 13 '22 15:12 twoldanski

Cool, thanks

tmotyl avatar Jan 02 '23 20:01 tmotyl

https://github.com/TYPO3-Headless/headless/pull/525 - new issue for v12

lukaszuznanski avatar Jan 03 '23 08:01 lukaszuznanski