TYPO3-CMS
Replace legacy bootstrap classes supported by FontAwesome
Bug Report
Prerequisites
- [X] Did you reproduce the problem on TYPO3 core master?
- [X] Did you reproduce the problem on TYPO3 v11.5 LTS?
Description
FontAwesome provides CSS classes that align with the old Bootstrap v3 classes, which will cause troubles with the removal of FontAwesome.
If this patch https://review.typo3.org/c/Packages/TYPO3.CMS/+/75342 is applied, a few classes are not available anymore. For example pull-left
Steps to Reproduce
- Apply https://review.typo3.org/c/Packages/TYPO3.CMS/+/75342
- Open Styleguide > Typography
Expected behavior: Colors are aligned left to right
Actual behavior: [What actually happened] Each color is rendered in one line each.
Versions
dev-main 7b1ccd6
Thanks for the bug report. If I'm not fully wrong, is this not fixed with the merged #342 ?
Just mentioning, FontAwesome is removed only in main, not v11. So I guess we do not need to change here anything for v11 style too.
@sbuerk the MR doesn't fully adress it. Within /Resources/Private/Templates/Backend/Typography.html there are still some pull-left classes, leading to missaligend color "blocks".
The "list-unstyled" styles are used in various places in the core and are provided by a bootstrap mixin.
Applicable locations: Build/Sources/Sass/backend.scss > Build/Sources/Sass/_minimal.scss > Build/node_modules/bootstrap/scss/mixins/_lists.scss
I couldn't find any other occurrences of Bootstrap classes in Typography.html. If applicable, these have now been removed.
Thanks Jasmina. I hope it's ok to close here since we think this has been resolved meanwhile, at least in styleguide main/v13.
