grabbit icon indicating copy to clipboard operation
grabbit copied to clipboard

Published 20 hours ago • verified publisher icon TWCable

issue-7 stop job client

Open viveksachdeva opened this issue 8 years ago • 5 comments

Old PR https://github.com/TWCable/grabbit/pull/146 had conflicts..

This one takes care of stopping jobs at client end.

viveksachdeva avatar Jan 09 '17 05:01 viveksachdeva

ReviewNinja

review-ninja avatar Jan 09 '17 05:01 review-ninja

Great! I'll take a look at this tomorrow

jbornemann avatar Jan 09 '17 09:01 jbornemann

If you are curious about how close() behaves in our case, check out org.apache.http.impl.io.ChunkedInputStream.close() (which is wrapped by our entities EofSensorInputStream class). You can see it continues to read into a 2KB buffer on close, until EOF is reached.

jbornemann avatar Jan 10 '17 10:01 jbornemann

This is a great start 👍 .. I agree with @jbornemann 's points as well.

sagarsane avatar Jan 11 '17 20:01 sagarsane

https://github.com/TWCable/grabbit/commit/1ffe73f087204075e48901641abf0fb070d63b2a is merged, so this may help with your progress on this branch

jbornemann avatar Jan 18 '17 04:01 jbornemann