gocast
gocast copied to clipboard
TUM-Dev
allow deselecting lecture halls in calendar
Motivation and Context
To have a quick glance about the events that are in a certain lecture hall it would be helpful if we were able to filter the events in the calendar. fixes #732
Description
This PR adds a checkbox for each lecture hall below the calendar. If a checkbox is checked we pass the id to the api which then includes that lecture hall in the result. The changes (logic wise) are done in SQL.
Steps for Testing
Prerequisites:
- Lecturers
- An admin
- generate events for different courses in different lecture halls.
- view the schedule as lectuer and verify that 2.1 filtering by lecture hall works. 2.2 The lecturer only sees their events.
- test that filtering also works for admins.
I pushed a few tiny fixes, this is what it looks like on my end now:
https://user-images.githubusercontent.com/44805696/197293618-63b5ddf1-c97f-495c-8634-7036d2e81fbf.mp4
I couldn't find out why your url didn't change, can you verify the latest commit?
I noticed small very short flickering
I think the fullCalendar needs some time to render the events unfortunately :/
I think the fullCalendar needs some time to render the events unfortunately :/
Hm, not really a problem, but might be worth to look whether there is an issue for this for fullCalendar.
I pushed a few tiny fixes, this is what it looks like on my end now:
Looks the same for me, looks good now!
I couldn't find out why your url didn't change, can you verify the latest commit?
I mean the URL did change after editing, but the request is sent twice. I recorded another gif to make sure we mean the same thing. Do you also have this?
@alexanderstephan nice catch! Apparently AddEventSource already triggers RefetchEventSources internally so the call was redundant.
